Closed Bug 1453067 Opened 2 years ago Closed 2 years ago

Taskcluster cron should support days

Categories

(Firefox Build System :: Task Configuration, task)

task
Not set

Tracking

(firefox-esr60 fixed, firefox61 fixed)

RESOLVED FIXED
mozilla61
Tracking Status
firefox-esr60 --- fixed
firefox61 --- fixed

People

(Reporter: sfraser, Assigned: sfraser)

References

Details

Attachments

(3 files)

We have a need to run scheduled tasks less frequently than once a day, and taskcluster cron currently only supports hours and minutes as options.
Assignee: nobody → sfraser
We need to run things less often than once a day, so adding support for
days to taskcluster cron. 'day' is the day of the month, 'weekday' is used
as a datetime.weekday (not isoweekday), or a string comparable to strftime('%A')
or strftime('%a')
Component: General → Task Configuration
Product: Taskcluster → Firefox Build System
Attachment #8966675 - Flags: review?(dustin)
Attachment #8966675 - Flags: review?(dustin) → review-
What were the improvements needed for the update?
Flags: needinfo?(dustin)
:heart: phabricator
Flags: needinfo?(dustin)
Oh, sorry, I thought Phabricator wasn't showing those to you.  I didn't see that you had updated the patch, or that you had made comments.  For whatever reason, it doesn't show me your comments inline, although it shows me my comments inline.  Egads, but this is unusable.

I think this looks good now.
Attachment #8966675 - Flags: review- → review+
Comment on attachment 8966675 [details]
Bug 1453067 Support for days (of week or month) in taskcluster cron r=dustin

One more update - I'd neglected to remove the tests for the numeric weekday last night, and adjust the elif condition in util.py
Attachment #8966675 - Flags: review+ → review?(dustin)
Comment on attachment 8966675 [details]
Bug 1453067 Support for days (of week or month) in taskcluster cron r=dustin

Dustin J. Mitchell [:dustin] pronoun: he has approved the revision.

https://phabricator.services.mozilla.com/D903
Attachment #8966675 - Flags: review+
Attachment #8966675 - Flags: review?(dustin)
Attachment #8966675 - Flags: review+
Pushed by sfraser@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/5ea0755f98af
Support for days (of week or month) in taskcluster cron r=dustin
Comment on attachment 8966675 [details]
Bug 1453067 Support for days (of week or month) in taskcluster cron r=dustin

Dustin J. Mitchell [:dustin] pronoun: he has approved the revision.

https://phabricator.services.mozilla.com/D903
Attachment #8966675 - Flags: review+
lol phabricator's a little late to the party here
https://hg.mozilla.org/mozilla-central/rev/5ea0755f98af
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
Blocks: 1454343
You need to log in before you can comment on or make changes to this bug.