Closed Bug 1453123 Opened 2 years ago Closed 2 years ago

CertUtils.jsm should export a CertUtils object, rather than having every caller that imports it creating one

Categories

(Toolkit :: Add-ons Manager, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla61
Tracking Status
firefox61 --- fixed

People

(Reporter: kmag, Assigned: kmag)

Details

Attachments

(1 file)

CertUtils.jsm currently exports a bunch of pseudo-random helper symbols. Every caller that imports them either creates a CertUtils object to hold those helpers, or just imports the module global. CertUtils should just export something sensible in the first place.
Comment on attachment 8966728 [details]
Bug 1453123: Have CertUtils export a CertUtils object.

https://reviewboard.mozilla.org/r/235426/#review241496
Attachment #8966728 - Flags: review?(rhelmer) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/57c0a4fc8ab6dfbb362c0102730a2d2cb1ba1ac1
Bug 1453123: Follow-up: Fix straggler CertUtils.jsm import. r=bustage CLOSED TREE
https://hg.mozilla.org/integration/mozilla-inbound/rev/0831a6f10eb3aa57b13134b345462afa3ac9730e
Bug 1453123: Follow-up: Fix straggler CertUtils.jsm import. r=bustage DONTBUILD CLOSED TREE
Please let us know if any testing is needed here or mark the bug as "qe-verify-"
Flags: needinfo?(kmaglione+bmo)
Flags: needinfo?(kmaglione+bmo) → qe-verify-
You need to log in before you can comment on or make changes to this bug.