1453129 - don't needlessly copy data in nsClipboardProxy

Status: RESOLVED FIXED

(Core :: Widget, enhancement)

Description

[Nathan Froyd [:froydnj]]

We're already going to copy the data when we initialize the
nsISupportsString here.  There's no need to copy the data into a
temporary object before passing it in to the nsISupportsString.

And as long as we're fixing the big mistakes, we might as well fix the
small ones, like copying the flavor string from the IPC object.

Comment 1

[Nathan Froyd [:froydnj]]

Attachment: don't needlessly copy data in nsClipboardProxy

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8966729 [details] [diff] [review]
don't needlessly copy data in nsClipboardProxy

Is IPC layer not using nsStringBuffers? If so, that is something to fix.

But we can do this anyhow.

Comment 3

[Nathan Froyd [:froydnj]]

(In reply to Olli Pettay [:smaug] (only webcomponents and event handling reviews, please) from comment #2)
> Comment on attachment 8966729 [details] [diff] [review]
> don't needlessly copy data in nsClipboardProxy
> 
> Is IPC layer not using nsStringBuffers? If so, that is something to fix.

Oh, that's true, we'd just increment a refcnt here.  OK, so it's not a huge win, but it looks nicer. :)

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/67758cf8ae6f
don't needlessly copy data in nsClipboardProxy; r=smaug

Comment 5

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/67758cf8ae6f