1453178 - Deletion of toolkit/content/select-child.js was lost in the rebase of bug 1300784

Status: RESOLVED FIXED

(Toolkit :: General, enhancement, P3)

Description

[Matthew N. [:MattN]]

We no longer package toolkit/content/select-child.js since bug 1300784 but the deletion of the file was lost in a rebase it seems. It's just dead code in the tree now.

To fix this bug simply delete the file and commit. e.g.
$ hg rm toolkit/content/select-child.js
$ hg commit -m "Bug XXX - Delete toolkit/content/select-child.js leftover from bug 1300784. r=MattN"
$ hg push review

Comment 1

[Manish [:manishkk]]

Attachment: Patch_Bug1453178

Please review.

Thanks

Comment 2

[Matthew N. [:MattN]]

Comment on attachment 8966888 [details] [diff] [review]
Patch_Bug1453178

Review of attachment 8966888 [details] [diff] [review]:
-----------------------------------------------------------------

Thank Manish! In the future can you include the r=MattN in the commit message so it's easier for sherrifs to land the patch. Or use mozreview which will do that for you: https://mozilla-version-control-tools.readthedocs.io/en/latest/mozreview.html

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/d2b067678e72
Deletion of toolkit/content/select-child.js was lost in the rebase of bug 1300784. r=MattN

Comment 4

[Eliza Balazs [:ebalazs_]]

https://hg.mozilla.org/mozilla-central/rev/d2b067678e72