Closed
Bug 1453205
Opened 6 years ago
Closed 6 years ago
Undo media.cubeb.sandbox pref flip in beta Snap packages
Categories
(Release Engineering :: Release Automation: Other, defect)
Tracking
(firefox59 unaffected, firefox60 affected, firefox61 affected)
RESOLVED
FIXED
| Tracking | Status | |
|---|---|---|
| firefox59 | --- | unaffected |
| firefox60 | --- | affected |
| firefox61 | --- | affected |
People
(Reporter: jld, Assigned: jld)
References
Details
Attachments
(1 file)
|
52 bytes,
text/x-github-pull-request
|
jlorenzo
:
review+
jlorenzo
:
checked-in+
|
Details | Review |
Bug 1449594 worked around an issue with sandboxing by flipping the media.cubeb.sandbox pref, but bug 1450740 should have fixed the underlying issue and the patch has been uplifted to beta, so it should be safe to revert the pref flip. Setting media.cubeb.sandbox to false does two things, neither of which are good: 1. Makes content processes use audio libraries directly instead of via the parent process; this is no longer the default on 60, isn't being tested, and might regress without being noticed. 2. As a side-effect, turns off the sandboxing improvements that are shipping in 60.
|
Assignee | |
Comment 1•6 years ago
|
||
Assignee: nobody → jld
Attachment #8968752 -
Flags: review?(jlorenzo)
|
||
Comment 2•6 years ago
|
||
Comment on attachment 8968752 [details] [review] Pull Request: Un-flip the media.cubeb.sandbox pref. Landed on master at: https://github.com/mozilla-partners/canonical/commit/23f45ce89d3c12847a6c8d389095c7b029ab760a
Attachment #8968752 -
Flags: review?(jlorenzo)
Attachment #8968752 -
Flags: review+
Attachment #8968752 -
Flags: checked-in+
|
|
||
Comment 3•6 years ago
|
||
Thanks for the details and the testing!
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•