1453224 - Remove nsStyleColor

Status: NEW

(Core :: CSS Parsing and Computation, enhancement, P3)

Description

[Xidorn Quan [:xidorn] UTC+11]

This style struct has only one 32bit field, it's not worth having a pointer in ComputedStyle and a refcount.

We should either merge it into some inherited struct, or have it embedded into ComputedStyle directly.

Comment 1

[Daniel Holbert [:dholbert]]

(Note that 'color' has to be computed before other properties, so we can determine the meaning of 'currentColor', which is a keyword that all other color-valued properties might use. I'm guessing that's why it's standalone.  But in the new stylo world, maybe this is easy to account for without needing a dedicated style struct.)

Comment 2

[Xidorn Quan [:xidorn] UTC+11]

All other color values should store currentcolor separately in computed value, i.e. they should use StyleComplexColor instead of mixing color property during computing. Color properties have mostly be updated, but color in other values, e.g. gradient, paint-server, may still need update. At the end, color shouldn't be required to compute before others.

Also Servo uses a property level early/other division, and it doesn't require a whole style struct to be computed together, so it isn't a problem even if we don't have currentcolor in computed value.