1453231 - [FTL] Copy from source using keyboard shortcut is broken

Status: RESOLVED FIXED

(Webtools Graveyard :: Pontoon, defect, P2)

Description

[Mohammed Ammar]

Attachment: Pontoon Simple FTL mode.jpg

User Agent: Mozilla/5.0 (Windows NT 6.1; rv:52.0) Gecko/20100101 Firefox/52.0
Build ID: 20100101

Steps to reproduce:

1. In Simple FTL mode, I copied source string using keyboard shortcut crtl+shift+c (as it doesn't have copy option in translation workspace.) 


Actual results:

the comment of the source string copied into Translation workspace instead of source  string.


Expected results:

Source string should be copied into translation workspace.

Comment 1

[Francesco Lodolo [:flod]]

It copies comments+strings, even in Advanced mode
https://pontoon.mozilla.org/fr/firefox/browser/browser/preferences/preferences.ftl/?search=firefox+home&string=177366

# "Firefox" should be treated as a brand and kept in English,
# while "Home" and "(Default)" can be localized.
home-mode-choice-default =
    .label = Firefox Home (Default)

Comment 2

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/pontoon/pull/947

Comment 3

[[github robot]]

Commit pushed to master at https://github.com/mozilla/pontoon

https://github.com/mozilla/pontoon/commit/1cfb649f9ff163f5ee259931e88b0d6736362a0d
Fix bug 1453231: [FTL] Disable copy shortcut for complex strings (#947)

When copy button is disabled (hidden), keyboard shortcut should be
disabled as well.