1453271 - Expose app version (GP) for each android build

Status: RESOLVED DUPLICATE of bug 1442306

(Release Engineering :: Release Automation: Other, enhancement)

Description

[Calixte Denizet (:calixte)]

The idea is to be able to have a mapping app-version <-> buildid.
Basically, on GP we've app versions (stats, crashes, ...) and it's pretty uneasy to guess what's the corresponding build.

Comment 1

[Johan Lorenzo [:jlorenzo]]

One way I see:
* the build task creates a new file with the Android App version in it
* we beetmove this file to archive.mozilla.org.
* pollbot[1] checks this file is present. I wonder if the mapping should happen in here. Although, I see the main developer is not at MoCo anymore. Thus, I don't know what's the best place to map it out.

[1] https://github.com/mozilla/PollBot

Comment 2

[Calixte Denizet (:calixte)]

Maybe we could add the app version in a file like http://archive.mozilla.org/pub/mobile/nightly/2018/04/2018-04-01-10-03-23-mozilla-central-android-aarch64/fennec-61.0a1.multi.android-aarch64.json and provide this info on buildhub.
:leplatrem, what do you think ?

Comment 3

[Mathieu Leplatre [:leplatrem]]

It would be relatively easy indeed to read new field in the release metadata file and stick it into buildhub.

However, I will have to pass the torch to Peter, who is currently revamping the archive.m.o integration using a new metadata file — dedicated to buildhub.

Comment 4

[Peter Bengtsson [:peterbe]]

Does that make sense?(In reply to Calixte Denizet (:calixte) from comment #2)
> Maybe we could add the app version in a file like
> http://archive.mozilla.org/pub/mobile/nightly/2018/04/2018-04-01-10-03-23-
> mozilla-central-android-aarch64/fennec-61.0a1.multi.android-aarch64.json and
> provide this info on buildhub.
> :leplatrem, what do you think ?


Disclaimer; I don't know what "app version (GP)" is. 

Right now we're not going to do any more feature work in terms of picking up data from the archive.mozilla.org that we don't already pick up. 

Instead, we're redirecting our attention to this: https://bugzilla.mozilla.org/show_bug.cgi?id=1442306
Basically, we gave Ted the JSON Schema Buildhub uses to store records. In particular, it's this: https://github.com/mozilla-services/buildhub/blob/53518a873b45daf497347ac71770859ec6ce2b8a/jobs/buildhub/initialization.yml#L71-L198

So what Ted is going to do is suck up all the pieces from build and make a `buildhub.json` file and store that. Buildhub will then scrape/S3 Event pick up that file and just open it, double-check that it conforms to the JSON Schema and then just store it. We will intentionally not dig into the content. Trying to avoid even understanding it. 

So, if you want something that's NOT available in that JSON Schema. E.g. "build.lucky_number<int>", the right thing is to file a bug on "Firefox Build System::General" (because that's where https://bugzilla.mozilla.org/show_bug.cgi?id=1442306 is filed) and ask for it to get included in the JSON Schema and the code that makes the buildhub.json file. 
If you manage to convince them of that and all works out, it'll just appear in Buildhub when you query it.

Comment 5

[Peter Bengtsson [:peterbe]]

PS. Note that when Ted got involved, he noticed that there were some fields he would like to add. See https://bugzilla.mozilla.org/show_bug.cgi?id=1442306#c2 So perhaps you could convince him to add whatever it is you need nowish. Good luck :)

Comment 6

[Johan Lorenzo [:jlorenzo]]

Thanks guys for the replies!

For reference, "app version (GP)" aka "Android version code" is an Android-specific buildId. It was made because Android doesn't support version codes with 14 digits. It's derived from the real build Id[1]. This value is generated at build time. Therefore, asking for this value in bug 1442306 makes sense to me. Calixte, what do you think of moving the request there and marking the current bug as a dupe?

[1] https://searchfox.org/mozilla-central/rev/bd326a2a6b729dc62a5aee57354a97ceac4d1dc0/python/mozbuild/mozbuild/android_version_code.py#33

Comment 7

[Calixte Denizet (:calixte)]

:jlorenzo, sure we can.
By the way, thx for the link, it will be useful.

Comment 8

[Johan Lorenzo [:jlorenzo]]

Marking as duplicate per comment 6 and comment 7. Please reopen if I missed anything.