Closed Bug 1453278 Opened 6 years ago Closed 6 years ago

[MIPS32] Add simulator single step profiling support

Categories

(Core :: JavaScript Engine: JIT, enhancement)

enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla61
Tracking Status
firefox61 --- fixed

People

(Reporter: dragan.mladjenovic, Assigned: dragan.mladjenovic)

Details

Attachments

(1 file)

      No description provided.
Attached patch bug1453278.patchSplinter Review
Includes a small nit to WasmModule.h to enable build with clang.
Assignee: nobody → dragan.mladjenovic
Attachment #8966936 - Flags: review?(bbouvier)
Comment on attachment 8966936 [details] [diff] [review]
bug1453278.patch

Review of attachment 8966936 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me, thanks!
Attachment #8966936 - Flags: review?(bbouvier) → review+
Keywords: checkin-needed
Pushed by cbrindusan@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/bcfee006ebaa
[MIPS32] Add simulator single step profiling support; r=bbouvier
Keywords: checkin-needed
(In reply to Eliza Balazs [:ebalazs_] from comment #4)
> Backed out 2 changesets (bug 1449364, bug 1453278) for rc4 and 42 perma
> failures in layout/base/tests/test_bug332655-2.html and testInputConnection
> 
> Push with failures:
> https://treeherder.mozilla.org/#/jobs?repo=mozilla-
> inbound&revision=7149139c60d98e3e5338795cb2be648136f2b9a4&filter-
> resultStatus=testfailed&filter-resultStatus=busted&filter-
> resultStatus=exception&filter-resultStatus=runnable&filter-
> resultStatus=success&selectedJob=173244342
> 
> Backout:
> https://treeherder.mozilla.org/#/jobs?repo=mozilla-
> inbound&revision=1f351e5132ab4f21dc117dc737c8e24e19d2e21a&filter-
> resultStatus=testfailed&filter-resultStatus=busted&filter-
> resultStatus=exception&filter-resultStatus=runnable&filter-
> resultStatus=success

Seems not related to this patch.
Flags: needinfo?(dragan.mladjenovic)
Keywords: checkin-needed
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/7205387e6dcc
[MIPS32] Add simulator single step profiling support; r=bbouvier
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/7205387e6dcc
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: