1453279 - ReferenceError: require is not defined when running tests in devtools/shared/tests/browser

Status: RESOLVED FIXED

(DevTools :: General, defect)

Description

[Johann Hofmann [:johannh]]

The test suite requires devtools/client/shared/test/shared-head.js which is not included by default if you run only tests from that directory.

Comment 1

[Johann Hofmann [:johannh]]

Attachment: Bug 1453279 - Include client/shared/test/shared-head.js in devtools/shared tests.

Review commit: https://reviewboard.mozilla.org/r/235606/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/235606/

Comment 2

[Julian Descottes [:jdescottes]]

Comment on attachment 8966925 [details]
Bug 1453279 - Include client/shared/test/shared-head.js in devtools/shared tests.

https://reviewboard.mozilla.org/r/235606/#review241354

Thanks! 
This fixes the issue (`mach clobber` followed by `mach test browser_l10n_localizeMarkup.js`)

::: commit-message-0528a:1
(Diff revision 1)
> +Bug 1453279 - Include client/shared/test/shared-head.js in devtools tests. r=jdescottes,nchevobbe

Can we be more specific and say "in devtools/shared tests." (other browser.ini already import shared-head correctly)

Comment 3

[Johann Hofmann [:johannh]]

Comment on attachment 8966925 [details]
Bug 1453279 - Include client/shared/test/shared-head.js in devtools/shared tests.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/235606/diff/1-2/

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4dd12c7c8f1f
Include client/shared/test/shared-head.js in devtools/shared tests. r=jdescottes

Comment 5

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/4dd12c7c8f1f