Closed
Bug 1453292
Opened 6 years ago
Closed 6 years ago
Remove Webdriver command "ElementTap"
Categories
(Testing :: geckodriver, enhancement, P1)
Testing
geckodriver
Tracking
(firefox64 fixed)
RESOLVED
FIXED
mozilla64
Tracking | Status | |
---|---|---|
firefox64 | --- | fixed |
People
(Reporter: whimboo, Assigned: ato, Mentored)
References
(Blocks 1 open bug)
Details
(Whiteboard: [lang=rust])
Attachments
(1 file, 1 obsolete file)
There is a "ElementTap" command present in both geckodriver and webdriver. But there is nothing like that listed in the WebDriver spec. In Marionette it calls `singleTap`, which is part of the old action API. Not sure when or why this has been added in the past. Maybe it was part of the spec at an earlier stage? Andreas, am I correct that this can be removed?
Flags: needinfo?(ato)
Reporter | ||
Comment 2•6 years ago
|
||
Great. So all references to this command can then be removed from any of the files under `testing/geckodriver` and `testing/webdriver`.
Mentor: hskupin
Whiteboard: [lang=rust]
Here is a patch removing ElementTap.
Attachment #8967982 -
Flags: review?(hskupin)
Reporter | ||
Comment 4•6 years ago
|
||
Comment on attachment 8967982 [details] [diff] [review] 0001-1-remove-ElementTap.patch Review of attachment 8967982 [details] [diff] [review]: ----------------------------------------------------------------- The patch looks fine and you should have covered each instance of ElementTap. But the commit message is incorrect because it references Marionette, and not geckodriver. Also maybe you could push your updated patch to mozreview? That would be fantastic because then I could easily create a try build to verify the changes. Thanks.
Attachment #8967982 -
Flags: review?(hskupin) → review-
Reporter | ||
Updated•6 years ago
|
Assignee: nobody → keremkat
Status: NEW → ASSIGNED
Assignee | ||
Updated•6 years ago
|
Priority: -- → P3
Assignee | ||
Comment 5•6 years ago
|
||
Do you have time and ability to fix up the patch?
Flags: needinfo?(keremkat)
Reporter | ||
Comment 7•6 years ago
|
||
Andreas, given that it was only the commit message which is wrong, maybe you can update and trigger a try build?
Assignee | ||
Updated•6 years ago
|
Assignee: keremkat → ato
Priority: P3 → P1
Assignee | ||
Updated•6 years ago
|
Assignee | ||
Updated•6 years ago
|
Attachment #8967982 -
Attachment is obsolete: true
Assignee | ||
Comment 8•6 years ago
|
||
Removes the non-standard /session/{session id}/element/{element id}/tap endpoint command from geckodriver.
Reporter | ||
Comment 9•6 years ago
|
||
Comment on attachment 9012046 [details] bug 1453292: webdriver, geckodriver: remove elementTap command Henrik Skupin (:whimboo) has approved the revision.
Attachment #9012046 -
Flags: review+
Comment 10•6 years ago
|
||
Pushed by atolfsen@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/f3ad3c9327b9 webdriver, geckodriver: remove elementTap command r=whimboo
Comment 11•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/f3ad3c9327b9
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox64:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
You need to log in
before you can comment on or make changes to this bug.
Description
•