1453312 - Record event for toolbox close

Status: RESOLVED FIXED

(DevTools :: General, enhancement, P2)

Comment 1

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Services.telemetry.recordEvent("devtools.main", "close", "tools", null, {"host": "bottom", "width": "1050"});

Comment 2

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Attachment: data-review.txt

Comment 3

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Attachment: Bug 1453312 - Record event for toolbox close

Changes:

1. The change in telemetry.js avoids an issue with overwriting pending properties.
2. The test in telemetry.md has been updated now that we have a working test.
3. Added the actual toolbox.close telemetry event and test.

Review commit: https://reviewboard.mozilla.org/r/235748/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/235748/

Comment 4

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Comment on attachment 8967088 [details]
Bug 1453312 - Record event for toolbox close

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/235748/diff/1-2/

Comment 5

[François Marier [:francois]]

Comment on attachment 8966979 [details]
data-review.txt

1) Is there or will there be **documentation** that describes the schema for the ultimate data set available publicly, complete and accurate?

Yes, in Events.yaml.

2) Is there a control mechanism that allows the user to turn the data collection on and off?

Yes, telemetry setting.

3) If the request is for permanent data collection, is there someone who will monitor the data over time?**

Yes, Harald Kirschner.

4) Using the **[category system of data types](https://wiki.mozilla.org/Firefox/Data_Collection)** on the Mozilla wiki, what collection type of data do the requested measurements fall under?  **

Category 1 or 2.

5) Is the data collection request for default-on or default-off?

Default on, all channels.

6) Does the instrumentation include the addition of **any *new* identifiers** (whether anonymous or otherwise; e.g., username, random IDs, etc.  See the appendix for more details)?

No.

7) Is the data collection covered by the existing Firefox privacy notice?

Yes.

8) Does there need to be a check-in in the future to determine whether to renew the data?

No, permament.

Comment 6

[Yulia Startsev [:yulia]]

Comment on attachment 8967088 [details]
Bug 1453312 - Record event for toolbox close

https://reviewboard.mozilla.org/r/235748/#review242240

Looks good, thanks!

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f60708e61cf4
Record event for toolbox close r=yulia

Comment 8

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/f60708e61cf4

Comment 9

[:Harald Kirschner :digitarald]

Moving to M1 for splitting off M2 work.