1453342 - Assertion failure: !(styleFrame && Servo_Element_IsDisplayContents(aElement)) (display: contents node has a frame, yet we didn't reframe it above?), at /builds/worker/workspace/build/src/layout/base/RestyleManager.cpp:2673

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[Jason Kratzer [:jkratzer]]

Attachment: trigger.html

Testcase found while fuzzing mozilla-central rev f6c3a0a19d82.

rax = 0x0000000000000000   rdx = 0x0000000000000000
rcx = 0x00007f7548da62dd   rbx = 0x00007f7527ee3650
rsi = 0x00007f7549075770   rdi = 0x00007f7549074540
rbp = 0x00007ffe06debaa0   rsp = 0x00007ffe06deb940
r8 = 0x00007f7549075770    r9 = 0x00007f754a13f740
r10 = 0x0000000000000039   r11 = 0x0000000000000000
r12 = 0x0000000000000000   r13 = 0x00007ffe06debb48
r14 = 0x00007f7527ee3650   r15 = 0x0000000006debb01
rip = 0x00007f75390179f9
OS|Linux|0.0.0 Linux 4.4.0-119-generic #143-Ubuntu SMP Mon Apr 2 16:08:24 UTC 2018 x86_64
CPU|amd64|family 6 model 78 stepping 3|1
GPU|||
Crash|SIGSEGV|0x0|0
0|0|libxul.so|mozilla::RestyleManager::ProcessPostTraversal|hg:hg.mozilla.org/mozilla-central:layout/base/RestyleManager.cpp:f6c3a0a19d82db25750d8badccd5cf37e79d028e|2617|0x18
0|1|libxul.so|mozilla::RestyleManager::ProcessPostTraversal|hg:hg.mozilla.org/mozilla-central:layout/base/RestyleManager.cpp:f6c3a0a19d82db25750d8badccd5cf37e79d028e|2773|0x25
0|2|libxul.so|mozilla::RestyleManager::DoProcessPendingRestyles|hg:hg.mozilla.org/mozilla-central:layout/base/RestyleManager.cpp:f6c3a0a19d82db25750d8badccd5cf37e79d028e|2980|0xf
0|3|libxul.so|mozilla::PresShell::DoFlushPendingNotifications|hg:hg.mozilla.org/mozilla-central:layout/base/PresShell.cpp:f6c3a0a19d82db25750d8badccd5cf37e79d028e|4283|0x19
0|4|libxul.so|nsIDocument::FlushPendingNotifications|hg:hg.mozilla.org/mozilla-central:layout/base/nsIPresShell.h:f6c3a0a19d82db25750d8badccd5cf37e79d028e|592|0xc
0|5|libxul.so|nsIDocument::FlushPendingNotifications|hg:hg.mozilla.org/mozilla-central:dom/base/nsDocument.cpp:f6c3a0a19d82db25750d8badccd5cf37e79d028e|7570|0x5
0|6|libxul.so|nsIDocument::FlushPendingNotifications|hg:hg.mozilla.org/mozilla-central:dom/base/nsDocument.cpp:f6c3a0a19d82db25750d8badccd5cf37e79d028e|7513|0x7
0|7|libxul.so|nsSMILAnimationController::DoSample|hg:hg.mozilla.org/mozilla-central:dom/smil/nsSMILAnimationController.cpp:f6c3a0a19d82db25750d8badccd5cf37e79d028e|439|0x17
0|8|libxul.so|nsSMILTimeContainer::Sample|hg:hg.mozilla.org/mozilla-central:dom/smil/nsSMILTimeContainer.cpp:f6c3a0a19d82db25750d8badccd5cf37e79d028e|185|0x9
0|9|libxul.so|nsIDocument::OnPageShow|hg:hg.mozilla.org/mozilla-central:dom/base/nsDocument.cpp:f6c3a0a19d82db25750d8badccd5cf37e79d028e|8498|0x14
0|10|libxul.so|nsDocumentViewer::LoadComplete|hg:hg.mozilla.org/mozilla-central:layout/base/nsDocumentViewer.cpp:f6c3a0a19d82db25750d8badccd5cf37e79d028e|1086|0x1d
0|11|libxul.so|nsDocShell::EndPageLoad|hg:hg.mozilla.org/mozilla-central:docshell/base/nsDocShell.cpp:f6c3a0a19d82db25750d8badccd5cf37e79d028e|7285|0x11
0|12|libxul.so|nsDocShell::OnStateChange|hg:hg.mozilla.org/mozilla-central:docshell/base/nsDocShell.cpp:f6c3a0a19d82db25750d8badccd5cf37e79d028e|7078|0x18
0|13|libxul.so|nsDocLoader::DoFireOnStateChange|hg:hg.mozilla.org/mozilla-central:uriloader/base/nsDocLoader.cpp:f6c3a0a19d82db25750d8badccd5cf37e79d028e|1315|0x2b
0|14|libxul.so|nsDocLoader::doStopDocumentLoad|hg:hg.mozilla.org/mozilla-central:uriloader/base/nsDocLoader.cpp:f6c3a0a19d82db25750d8badccd5cf37e79d028e|858|0x22
0|15|libxul.so|nsDocLoader::DocLoaderIsEmpty|hg:hg.mozilla.org/mozilla-central:uriloader/base/nsDocLoader.cpp:f6c3a0a19d82db25750d8badccd5cf37e79d028e|747|0xf
0|16|libxul.so|nsDocLoader::OnStopRequest|hg:hg.mozilla.org/mozilla-central:uriloader/base/nsDocLoader.cpp:f6c3a0a19d82db25750d8badccd5cf37e79d028e|632|0x16
0|17|libxul.so|mozilla::net::nsLoadGroup::RemoveRequest|hg:hg.mozilla.org/mozilla-central:netwerk/base/nsLoadGroup.cpp:f6c3a0a19d82db25750d8badccd5cf37e79d028e|629|0x1f
0|18|libxul.so|nsIDocument::DoUnblockOnload|hg:hg.mozilla.org/mozilla-central:dom/base/nsDocument.cpp:f6c3a0a19d82db25750d8badccd5cf37e79d028e|8409|0x20
0|19|libxul.so|nsDocument::UnblockOnload|hg:hg.mozilla.org/mozilla-central:dom/base/nsDocument.cpp:f6c3a0a19d82db25750d8badccd5cf37e79d028e|8331|0x8
0|20|libxul.so|nsIDocument::DispatchContentLoadedEvents|hg:hg.mozilla.org/mozilla-central:dom/base/nsDocument.cpp:f6c3a0a19d82db25750d8badccd5cf37e79d028e|5314|0x11
0|21|libxul.so|mozilla::detail::RunnableMethodImpl<nsIDocument*, void (nsIDocument::*)(), true, (mozilla::RunnableKind)0u>::Run|hg:hg.mozilla.org/mozilla-central:xpcom/threads/nsThreadUtils.h:f6c3a0a19d82db25750d8badccd5cf37e79d028e|1164|0x13
0|22|libxul.so|mozilla::SchedulerGroup::Runnable::Run|hg:hg.mozilla.org/mozilla-central:xpcom/threads/SchedulerGroup.cpp:f6c3a0a19d82db25750d8badccd5cf37e79d028e|337|0x15
0|23|libxul.so|nsThread::ProcessNextEvent|hg:hg.mozilla.org/mozilla-central:xpcom/threads/nsThread.cpp:f6c3a0a19d82db25750d8badccd5cf37e79d028e|1096|0x15
0|24|libxul.so|NS_ProcessNextEvent|hg:hg.mozilla.org/mozilla-central:xpcom/threads/nsThreadUtils.cpp:f6c3a0a19d82db25750d8badccd5cf37e79d028e|519|0x11
0|25|libxul.so|mozilla::ipc::MessagePump::Run|hg:hg.mozilla.org/mozilla-central:ipc/glue/MessagePump.cpp:f6c3a0a19d82db25750d8badccd5cf37e79d028e|97|0xa
0|26|libxul.so|MessageLoop::RunInternal|hg:hg.mozilla.org/mozilla-central:ipc/chromium/src/base/message_loop.cc:f6c3a0a19d82db25750d8badccd5cf37e79d028e|326|0x17
0|27|libxul.so|MessageLoop::Run|hg:hg.mozilla.org/mozilla-central:ipc/chromium/src/base/message_loop.cc:f6c3a0a19d82db25750d8badccd5cf37e79d028e|319|0x8
0|28|libxul.so|nsBaseAppShell::Run|hg:hg.mozilla.org/mozilla-central:widget/nsBaseAppShell.cpp:f6c3a0a19d82db25750d8badccd5cf37e79d028e|157|0xd
0|29|libxul.so|XRE_RunAppShell|hg:hg.mozilla.org/mozilla-central:toolkit/xre/nsEmbedFunctions.cpp:f6c3a0a19d82db25750d8badccd5cf37e79d028e|893|0x11
0|30|libxul.so|mozilla::ipc::MessagePumpForChildProcess::Run|hg:hg.mozilla.org/mozilla-central:ipc/glue/MessagePump.cpp:f6c3a0a19d82db25750d8badccd5cf37e79d028e|269|0x5
0|31|libxul.so|MessageLoop::RunInternal|hg:hg.mozilla.org/mozilla-central:ipc/chromium/src/base/message_loop.cc:f6c3a0a19d82db25750d8badccd5cf37e79d028e|326|0x17
0|32|libxul.so|MessageLoop::Run|hg:hg.mozilla.org/mozilla-central:ipc/chromium/src/base/message_loop.cc:f6c3a0a19d82db25750d8badccd5cf37e79d028e|319|0x8
0|33|libxul.so|XRE_InitChildProcess|hg:hg.mozilla.org/mozilla-central:toolkit/xre/nsEmbedFunctions.cpp:f6c3a0a19d82db25750d8badccd5cf37e79d028e|719|0x8
0|34|firefox|content_process_main|hg:hg.mozilla.org/mozilla-central:ipc/contentproc/plugin-container.cpp:f6c3a0a19d82db25750d8badccd5cf37e79d028e|50|0x14
0|35|firefox|main|hg:hg.mozilla.org/mozilla-central:browser/app/nsBrowserApp.cpp:f6c3a0a19d82db25750d8badccd5cf37e79d028e|280|0x11
0|36|libc-2.23.so||||0x20830
0|37|firefox|MOZ_ReportAssertionFailure|hg:hg.mozilla.org/mozilla-central:mfbt/Assertions.h:f6c3a0a19d82db25750d8badccd5cf37e79d028e|164|0x5

Comment 1

[Emilio Cobos Álvarez (:emilio)]

This is going to be fixed by bug 1453702.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/b657b7a34615
Crashtest. r=emilio

Comment 3

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/b657b7a34615