Looks like this is one of the problems: https://hg.mozilla.org/mozilla-central/diff/c1dc65552300/docshell/base/nsIWebNavigation.idl#l1.39 - attribute nsISHistory sessionHistory; + [binaryname(SessionHistoryXPCOM)] + readonly attribute nsISupports sessionHistory; We set this attribute at specialTabs.js, line 579: browser.webNavigation.sessionHistory = Cc["@mozilla.org/browser/shistory;1"] .createInstance(Ci.nsISHistory);
I suspect you want to replace this: browser.webNavigation.sessionHistory = Cc["@mozilla.org/browser/shistory;1"] .createInstance(Ci.nsISHistory); with: browser.docShell.initSessionHistory(); in specialTabs.js. That should fix that problem. If that doesn't fix the folderPane bit I can't tell you what's up with that. The toolbar.xml bit is bug 1452059, right?
With my bustage fix patch the folder pane is back, that's a follow-on problem. I hadn't seen the statusText bit before, yes, it belongs in the other bug. I'll try your fix now.
Summary: Thunderbird busted 2018-04-11: No tabs or folder tree → Port Bug 1434768 - Basic structure for new session history APIs - Thunderbird busted 2018-04-11: No tabs or folder tree
This works, thanks Boris!
Assignee: nobody → jorgk
Attachment #8967039 - Attachment is obsolete: true
Status: NEW → ASSIGNED
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/comm-central/rev/0ddd82b04560 Port Bug 1434768: Use new session history APIs. rs=bustage-fix
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Boris, thanks for your help. I landed this in a hurry and see no test failures. Any other APIs we need to replace?
Could be. See https://bug1434768.bmoattachments.org/attachment.cgi?id=8950367 for the JS changes that got made to Firefox. I see no uses of .sessionHistory in https://searchfox.org/comm-central/search?q=.sessionHistory&case=true®exp=false&path=mail so that part looks ok. Similar for calendar/. Might be worth quickly checking for use of nsISHistory APIs, though. There are a bunch in suite/ and those are likely broken now...
Thanks Boris. As you said .sessionHistory is only in the suite/ part of C-C. The same goes for nsISHistory APIs by which I suppose you mean nsISHistory*, so nsISHistory, nsISHistoryListener and nsISHistoryInternal. FRG, this needs porting, especially assigning to .sessionHistory won't work any more: suite/common/helpviewer/help.js 130 getWebNavigation().sessionHistory =
Thanks Jorg. Put it in our master bug for later porting. Currently fixing up 60.
You need to log in before you can comment on or make changes to this bug.