Closed Bug 145338 Opened 18 years ago Closed 18 years ago
Add external/virtual dependency mechanism for bootstrap
Add external, optional dependency mechanism for bootstrap.pl. This would add dependencies for disconnected modules. Specifically, the following dependencies are not part of the all.dot file because the modules are pluggable/disconnected from the rest of the tree: imglib2 -> png imglib2 -> jpeg imglib2 -> mng
I think I slightly disagree on the design. instead of adding implicit dependencies on an existing module, I'm imagining something like a "virtual" module that includes a series of packages so it would be something like: gtkmozembedplus -> gtkmozembed; gtkmozembedplus -> imagedecoders; imagedecoders -> png; imagedecoders -> gif; and so forth. that way, if you suck all the .dot files into memory, the "virtual" dependencies are still obvious, and not hidden inside of the imglib2 module.
Assignee: adamlock → blythe
ok I'll buy into alec's idea, that will be a little more maintainable too.
resummarizing per alecf's comment.
Summary: extra.dot: Add external, optional dependency mechanism for bootstrap.pl → Add external/virtual dependency mechanism for bootstrap.pl
Assignee: blythe → mcafee
patch creates intermediate v-imagedecoders module. Using "v-" prefix to keep virtual modules separate from the real ones in the module namespace. Using a prefix so that sorted module lists (if needed) would show virtual modules clumped together. wrapper for gtkembedmoz is called "gtkembedmoz-wrap", wrap sounded better than plus to me. usage of bootstrap.pl for gtkembedmoz will now be bootstrap.pl --module=gtkembedmoz-wrap
just out of curiosity, what exactly does "wrap" refer to? :)
wrapper. :) Are you voting for plus? Give me a better name and I'll use it.
Comment on attachment 84504 [details] [diff] [review] Adding gtkembedmoz-wrap virtual dependencies in extra.dot. Changes in bootstrap.pl to append extra.dot dependencies to all.dot (resulting file called meta.dot) ah, I had "wrap == word wrap" stuck in my head - how about "wrapper" over "wrap" as in gtkmozembed-wrapper then? oh, sr=alecf while I'm here :)
Attachment #84504 - Flags: superreview+
Comment on attachment 84504 [details] [diff] [review] Adding gtkembedmoz-wrap virtual dependencies in extra.dot. Changes in bootstrap.pl to append extra.dot dependencies to all.dot (resulting file called meta.dot) r=blythe
Attachment #84504 - Flags: review+
wrapper it is. Also note, just appending to the all.dot file loses the build order, and we'll need to put these libs in the order file.
I think this is fixed, ordering problem is bug 145333.
Status: NEW → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
To ashish for bug verification
QA Contact: mdunn → ashishbhatt
You need to log in before you can comment on or make changes to this bug.