1453380 - Bump the mirror schema version and trash version 1 mirrors

Status: RESOLVED DUPLICATE of bug 1451537

(Firefox :: Sync, enhancement)

Description

[Lina Butler [:lina]]

See bug 1453257. Older Nightlies used a different schema (changed in bug 1426556); if you sync with one, or flipped the pref manually, you'll get datatype mismatch errors when we go to update the sync ID.

I think we can just throw for version 1 databases, and have our corruption recovery logic trash the database and start over.

On a related note, I didn't think about profile downgrades. :-( What happens if you flip the pref on 61, then downgrade to 60? You'll likely run into bug 1435446. I guess we could uplift a patch for 60 only that removes https://searchfox.org/mozilla-central/rev/6bfadf95b4a6aaa8bb3b2a166d6c3545983e179a/services/sync/modules/service.js#56-66, so it ignores the pref and always uses the old engine.

Comment 1

[Lina Butler [:lina]]

Let's hold off on this until we see more reports. For now, we can point folks who run Nightly and manually flipped the pref to bug 1453257, and keep an eye on engine errors.

Comment 2

[Lina Butler [:lina]]

(In reply to Kit Cambridge (they/them) [:kitcambridge] from comment #0)
> I think we can just throw for version 1 databases, and have our corruption
> recovery logic trash the database and start over.

This is handled in bug 1451537, so duping to that.

> On a related note, I didn't think about profile downgrades. :-( What happens
> if you flip the pref on 61, then downgrade to 60? You'll likely run into bug
> 1435446. I guess we could uplift a patch for 60 only that removes
> https://searchfox.org/mozilla-central/rev/
> 6bfadf95b4a6aaa8bb3b2a166d6c3545983e179a/services/sync/modules/service.js#56-
> 66, so it ignores the pref and always uses the old engine.

This landed in bug 1453449.