Closed Bug 1453413 Opened 2 years ago Closed 2 years ago
Use aapt2 to build Firefox for Android
59 bytes, text/x-review-board-request
For historical reasons, Firefox for Android builds without aapt2 (the latest version of the resource processing algorithm in the Android-Gradle build plugin). This was largely "just" because our Robolectric based unit tests didn't support aapt2 on day one -- see https://github.com/robolectric/robolectric/issues/3169 and related issues. This is no longer a problem, and it's technically possible that bugs like those linked in the meta-ticket https://bugzilla.mozilla.org/show_bug.cgi?id=1450105 are related to aapt/aapt2 distinction, so we'd like to upgrade to the newest tooling.
Comment on attachment 8967085 [details] Bug 1453413 - Use aapt2 to build Firefox for Android. https://reviewboard.mozilla.org/r/235740/#review241946 I don't have a clear idea of what aapt does but: - Using old tooling/APIs has caused problems in the past so I wouldn't put it past them - This is a good start for trying to identify what's causing those crazy crashes - We're using aapt2 in focus/firefox TV, afaik
Attachment #8967085 - Flags: review?(michael.l.comella) → review+
I guess I should have taken two minutes to read: "Android Asset Packaging Tool". Those crazy crash bugs seem related to R.java offsets, i.e. asset packaging, so this sounds like a *really* good idea. :)
Pushed by email@example.com: https://hg.mozilla.org/integration/autoland/rev/787dce710dce Use aapt2 to build Firefox for Android. r=mcomella
Product: Firefox for Android → Firefox Build System
Target Milestone: Firefox 61 → mozilla61
You need to log in before you can comment on or make changes to this bug.