Closed
Bug 1453415
Opened 6 years ago
Closed 6 years ago
Fix handling of crashes
Categories
(Testing :: web-platform-tests, enhancement)
Tracking
(firefox61 fixed)
RESOLVED
FIXED
mozilla61
Tracking | Status | |
---|---|---|
firefox61 | --- | fixed |
People
(Reporter: jgraham, Assigned: jgraham)
Details
Attachments
(2 files)
2.89 KB,
patch
|
ato
:
review+
|
Details | Diff | Splinter Review |
1.03 KB,
patch
|
ato
:
review+
|
Details | Diff | Splinter Review |
With the testdriver changes, the crash handling in Firefox broke as we missed the fact that execute_async_script could return None after a crash, rather than an exception being raised.
Assignee | ||
Comment 1•6 years ago
|
||
Attachment #8967997 -
Flags: review?(mjzffr)
Attachment #8967997 -
Flags: review?(ato)
Assignee | ||
Comment 2•6 years ago
|
||
Attachment #8967998 -
Flags: review?(mjzffr)
Attachment #8967998 -
Flags: review?(ato)
Updated•6 years ago
|
Attachment #8967997 -
Flags: review?(ato) → review+
Updated•6 years ago
|
Attachment #8967998 -
Flags: review?(ato) → review+
Pushed by james@hoppipolla.co.uk: https://hg.mozilla.org/integration/mozilla-inbound/rev/0d55caa97d7e Handle marionette returning None for content process crash, r=ato https://hg.mozilla.org/integration/mozilla-inbound/rev/ebfad4be630d Don't try to pause after a crashed test, r=ato
Created web-platform-tests PR https://github.com/w3c/web-platform-tests/pull/10479 for changes under testing/web-platform/tests
Upstream web-platform-tests status checks passed, PR will merge once commit reaches central.
Comment 6•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/0d55caa97d7e https://hg.mozilla.org/mozilla-central/rev/ebfad4be630d
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox61:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
Can't merge web-platform-tests PR due to failing upstream checks: Github PR https://github.com/w3c/web-platform-tests/pull/10479 * continuous-integration/travis-ci/pr (https://travis-ci.org/w3c/web-platform-tests/builds/367564540?utm_source=github_status&utm_medium=notification)
Attachment #8967997 -
Flags: review?(mjzffr)
Attachment #8967998 -
Flags: review?(mjzffr)
Updated•6 years ago
|
Assignee: nobody → james
Upstream PR merged
You need to log in
before you can comment on or make changes to this bug.
Description
•