Closed Bug 1453415 Opened 2 years ago Closed 2 years ago

Fix handling of crashes

Categories

(Testing :: web-platform-tests, enhancement)

Version 3
enhancement
Not set

Tracking

(firefox61 fixed)

RESOLVED FIXED
mozilla61
Tracking Status
firefox61 --- fixed

People

(Reporter: jgraham, Assigned: jgraham)

Details

Attachments

(2 files)

With the testdriver changes, the crash handling in Firefox broke as we missed the fact that execute_async_script could return None after a crash, rather than an exception being raised.
Attached patch 1453415-1.diffSplinter Review
Attachment #8967997 - Flags: review?(mjzffr)
Attachment #8967997 - Flags: review?(ato)
Attached patch 1453415-2.diffSplinter Review
Attachment #8967998 - Flags: review?(mjzffr)
Attachment #8967998 - Flags: review?(ato)
Attachment #8967997 - Flags: review?(ato) → review+
Attachment #8967998 - Flags: review?(ato) → review+
Pushed by james@hoppipolla.co.uk:
https://hg.mozilla.org/integration/mozilla-inbound/rev/0d55caa97d7e
Handle marionette returning None for content process crash, r=ato
https://hg.mozilla.org/integration/mozilla-inbound/rev/ebfad4be630d
Don't try to pause after a crashed test, r=ato
Created web-platform-tests PR https://github.com/w3c/web-platform-tests/pull/10479 for changes under testing/web-platform/tests
Upstream web-platform-tests status checks passed, PR will merge once commit reaches central.
https://hg.mozilla.org/mozilla-central/rev/0d55caa97d7e
https://hg.mozilla.org/mozilla-central/rev/ebfad4be630d
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
Assignee: nobody → james
Upstream PR merged
You need to log in before you can comment on or make changes to this bug.