Closed
Bug 1453435
Opened 6 years ago
Closed 6 years ago
Invalid strings "SCTs records" for certificate transparency in the network monitor
Categories
(DevTools :: Netmonitor, enhancement)
Tracking
(firefox61 fixed)
RESOLVED
FIXED
Firefox 61
Tracking | Status | |
---|---|---|
firefox61 | --- | fixed |
People
(Reporter: vincent, Assigned: vincent)
Details
Attachments
(1 file)
Follow-up from this comment [0] in bug 1313511. "SCTs records" needs to be replaced by "SCT records" in this file [1] [0] https://bugzilla.mozilla.org/show_bug.cgi?id=1313511#c28 [1] https://dxr.mozilla.org/mozilla-central/source/devtools/client/locales/en-US/netmonitor.properties#477
Assignee | ||
Updated•6 years ago
|
Assignee: nobody → vi.le
Status: NEW → ASSIGNED
Comment hidden (mozreview-request) |
Comment 2•6 years ago
|
||
mozreview-review |
Comment on attachment 8967975 [details] Bug 1453435 - Correct wording for labels used by the certificate transparency UI in the netmonitor; https://reviewboard.mozilla.org/r/236666/#review242540 Thanks for working one this! Plese see my inline question. Honza ::: devtools/client/locales/en-US/netmonitor.properties:485 (Diff revision 1) > > # LOCALIZATION NOTE (certmgr.certificateTransparency.status.notEnoughSCTS): > # This string is used to indicate that there are not enough valid signed > # certificate timestamps. This is a property for the 'Transparency' > # field in the security tab. > certmgr.certificateTransparency.status.notEnoughSCTS=Not enough SCTs This label is ok? (note that there is yet one `Not diverse SCTs`)
Updated•6 years ago
|
Flags: needinfo?(vi.le)
Assignee | ||
Comment 3•6 years ago
|
||
mozreview-review-reply |
Comment on attachment 8967975 [details] Bug 1453435 - Correct wording for labels used by the certificate transparency UI in the netmonitor; https://reviewboard.mozilla.org/r/236666/#review242540 > This label is ok? > (note that there is yet one `Not diverse SCTs`) Yes, I think this is correct. SCTs means 'Signed Certificate Timestamps' so 'Not enough SCTs' means 'Not enough Signed Certificate Timestamps'. This patch changes 'No SCTs records' because it means 'No Signed Certificate Timestamps records' which is weird, so I remove the 's'. Same for the other string
Assignee | ||
Updated•6 years ago
|
Flags: needinfo?(vi.le)
Assignee | ||
Updated•6 years ago
|
Flags: needinfo?(odvarko)
Comment 4•6 years ago
|
||
mozreview-review |
Comment on attachment 8967975 [details] Bug 1453435 - Correct wording for labels used by the certificate transparency UI in the netmonitor; https://reviewboard.mozilla.org/r/236666/#review244136 Thanks for the explanation R+ assuming try is green. Thanks for the patch! Honza
Attachment #8967975 -
Flags: review?(odvarko) → review+
Updated•6 years ago
|
Flags: needinfo?(odvarko)
Assignee | ||
Comment 5•6 years ago
|
||
Push to try here: https://treeherder.mozilla.org/#/jobs?repo=try&revision=d6f265a234f9a77eec6110da751beddebd0b1aa4
Assignee | ||
Updated•6 years ago
|
Keywords: checkin-needed
Assignee | ||
Comment 6•6 years ago
|
||
I don't see any issues with the try push.
Pushed by ryanvm@gmail.com: https://hg.mozilla.org/integration/autoland/rev/7bbee469249d Correct wording for labels used by the certificate transparency UI in the netmonitor; r=Honza
Keywords: checkin-needed
Comment 8•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/7bbee469249d
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 61
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•