Invalid strings "SCTs records" for certificate transparency in the network monitor

RESOLVED FIXED in Firefox 61

Status

enhancement
--
minor
RESOLVED FIXED
Last year
Last year

People

(Reporter: vi.le, Assigned: vi.le)

Tracking

Trunk
Firefox 61
Unspecified
All

Firefox Tracking Flags

(firefox61 fixed)

Details

Attachments

(1 attachment)

Follow-up from this comment [0] in bug 1313511.

"SCTs records" needs to be replaced by "SCT records" in this file [1]

[0] https://bugzilla.mozilla.org/show_bug.cgi?id=1313511#c28
[1] https://dxr.mozilla.org/mozilla-central/source/devtools/client/locales/en-US/netmonitor.properties#477
Assignee: nobody → vi.le
Status: NEW → ASSIGNED
Comment on attachment 8967975 [details]
Bug 1453435 - Correct wording for labels used by the certificate transparency UI in the netmonitor;

https://reviewboard.mozilla.org/r/236666/#review242540

Thanks for working one this!

Plese see my inline question.

Honza

::: devtools/client/locales/en-US/netmonitor.properties:485
(Diff revision 1)
>  
>  # LOCALIZATION NOTE (certmgr.certificateTransparency.status.notEnoughSCTS):
>  # This string is used to indicate that there are not enough valid signed
>  # certificate timestamps. This is a property for the 'Transparency'
>  # field in the security tab.
>  certmgr.certificateTransparency.status.notEnoughSCTS=Not enough SCTs

This label is ok?
(note that there is yet one `Not diverse SCTs`)
Comment on attachment 8967975 [details]
Bug 1453435 - Correct wording for labels used by the certificate transparency UI in the netmonitor;

https://reviewboard.mozilla.org/r/236666/#review242540

> This label is ok?
> (note that there is yet one `Not diverse SCTs`)

Yes, I think this is correct. SCTs means 'Signed Certificate Timestamps' so 'Not enough SCTs' means 'Not enough Signed Certificate Timestamps'.

This patch changes 'No SCTs records' because it means 'No Signed Certificate Timestamps records' which is weird, so I remove the 's'. Same for the other string
Flags: needinfo?(vi.le)
Flags: needinfo?(odvarko)
Comment on attachment 8967975 [details]
Bug 1453435 - Correct wording for labels used by the certificate transparency UI in the netmonitor;

https://reviewboard.mozilla.org/r/236666/#review244136

Thanks for the explanation
R+ assuming try is green.

Thanks for the patch!

Honza
Attachment #8967975 - Flags: review?(odvarko) → review+
Keywords: checkin-needed
I don't see any issues with the try push.
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/7bbee469249d
Correct wording for labels used by the certificate transparency UI in the netmonitor; r=Honza
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/7bbee469249d
Status: ASSIGNED → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → Firefox 61
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.