1453437 - return UniquePtr from MediaRawData::CreateWriter

Status: RESOLVED FIXED

(Core :: Audio/Video, enhancement)

Description

[Nathan Froyd [:froydnj]]

Returning UniquePtr is nicer than returning raw pointers, and has the
nice side effect of forcing us to clean up the uses of nsAutoPtr that
were hanging about.

Comment 1

[Nathan Froyd [:froydnj]]

Attachment: return UniquePtr from MediaRawData::CreateWriter

Kind of wonder whether MediaRawDataWriter should be heap-allocated at all, but
perhaps that is a cleanup for another time.

Comment 2

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Comment on attachment 8967108 [details] [diff] [review]
return UniquePtr from MediaRawData::CreateWriter

Review of attachment 8967108 [details] [diff] [review]:
-----------------------------------------------------------------

Thank you for scratching that itch.

Unimportant nit:

::: dom/media/MediaData.h
@@ +701,5 @@
>  
>    // Return a deep copy or nullptr if out of memory.
>    virtual already_AddRefed<MediaRawData> Clone() const;
> +  // Create a MediaRawDataWriter for this MediaRawData. The writer is not
> +  // thread-safe

You've lost the final '.' in the rewrite.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/aa7373395767
return UniquePtr from MediaRawData::CreateWriter; r=gerald

Comment 4

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/aa7373395767