Completely disable the buffered bookmarks engine in 60

RESOLVED FIXED in Firefox 60

Status

()

RESOLVED FIXED
10 months ago
10 months ago

People

(Reporter: lina, Assigned: lina)

Tracking

unspecified
Firefox 60
Points:
---
Bug Flags:
qe-verify -

Firefox Tracking Flags

(firefox59 unaffected, firefox60 fixed, firefox61 unaffected)

Details

Attachments

(1 attachment)

(Assignee)

Description

10 months ago
The buffered bookmarks engine landed in 60, pref'd off by default (bug 1305563). However, we're currently running a SHIELD study to flip the pref on in 61, and eventually enable the engine by default for everyone in 61 or 62.

If folks enable the engine on Nightly 61, then use the same profile in Beta 60, they'll likely run into bug 1435446. Bookmark changes will be ignored, the awesomebar will be broken, and Firefox will hang on shutdown until the next restart.

We didn't uplift bug 1435446 to Beta because it changes how we run all Places database transactions, which is risky. 61 also includes a backward-incompatible schema change (bug 1453257), which will cause syncs run with the buffered engine in 60 to fail.

Even though we don't support profile downgrades, we don't want Sync users running into bug 1435446 on Beta. It's a minimally invasive change to make the pref a no-op on 60, so I think we should do that.
(Assignee)

Updated

10 months ago
status-firefox59: --- → unaffected
status-firefox60: --- → affected
status-firefox61: --- → unaffected
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
(Assignee)

Updated

10 months ago
No longer blocks: 1453380
See Also: → bug 1453380

Comment 3

10 months ago
mozreview-review
Comment on attachment 8967129 [details]
Bug 1453449 - Completely disable the buffered bookmarks engine in 60.

https://reviewboard.mozilla.org/r/235772/#review241618

LGTM.
Attachment #8967129 - Flags: review?(tchiovoloni) → review+
(Assignee)

Comment 4

10 months ago
Comment on attachment 8967129 [details]
Bug 1453449 - Completely disable the buffered bookmarks engine in 60.

This patch is for m-b only, it should *not* land on m-c.

Approval Request Comment
[Feature/Bug causing the regression]: Bug 1305563.
[User impact if declined]: Users who opt in to the new bookmarks engine in 61, then downgrade and use their profiles in 60, will experience shutdown hangs, and issues with editing bookmarks, saving history, and using the awesomebar.
[Is this code covered by automated tests?]: https://treeherder.mozilla.org/#/jobs?repo=try&revision=31f86959b420611cf56eb9cf79d107cde2e48e11
[Has the fix been verified in Nightly?]: No, this fix should not land in Nightly.
[Needs manual test from QE? If yes, steps to reproduce]: No.
[List of other uplifts needed for the feature/fix]: None.
[Is the change risky?]: No.
[Why is the change risky/not risky?]: This is a small patch that removes a pref check and unconditionally uses the old bookmarks engine, even if the pref is set.
[String changes made/needed]: None.
Attachment #8967129 - Flags: approval-mozilla-beta?
Comment on attachment 8967129 [details]
Bug 1453449 - Completely disable the buffered bookmarks engine in 60.

neuter engine.bookmarks.buffer pref in 60, approved for 60.0b12
Attachment #8967129 - Flags: approval-mozilla-beta? → approval-mozilla-beta+

Comment 6

10 months ago
bugherderuplift
https://hg.mozilla.org/releases/mozilla-beta/rev/04cc6231a6f4
status-firefox60: affected → fixed
Status: ASSIGNED → RESOLVED
Last Resolved: 10 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 60
Setting qe-verify- based on Kit's assessment on manual testing needs (Comment 4) and the fact that this fix has automated tests.
Flags: qe-verify-
You need to log in before you can comment on or make changes to this bug.