Closed Bug 145347 Opened 18 years ago Closed 18 years ago
Liveconnect needs it's own module name
oji needs liveconnect, but liveconnect is ifdef'd into the build in the top-level makefile, which the REQUIRES/embed build doesn't see: [mozilla/Makefile.in] ifdef MOZ_OJI tier_9_dirs += js/src/liveconnect endif Liveconnect is currently (conditionally) part of the java module. [from email/meeting] cls: Strange. oji should also be using that same ifdef. For some reason, the MOZ_OJI ifdef for oji is buried in the modules/oji/src/Makefile.in . I think it's so that we still export the headers but don't build the lib. We might want to change that as well.
for the record, here's the error: [/builds/mcafee/gmonkey/mozilla/modules/oji/src/jvmmgr.cpp] In file included from nsJVMManager.h:41, from jvmmgr.cpp:39: jvmmgr.h:46:32: nsISecurityContext.h: No such file or directory
so we're sure this isn't another module-within-a-module problem again?
Adding liveconnect to the java module in module2dir.pl (diff:) - 'java', 'sun-java/stubs', + 'java', 'sun-java/stubs js/jsd/classes js/src/liveconnect', seems to fix this. I hesitated to do this because the MOZ_OJI ifdef crossed over the module boundary, but ? maybe I'm worrying too much. This diff is covered in the patch for bug 143399 that I just submitted. Things are building for me now.
I also tried splitting liveconnect out of the java module into its own module, this seemed to work as well. This might be overkill compared with solution above, comments?
Comment on attachment 86570 [details] [diff] [review] Patch to split liveconnect off from the java module. I personall prefer the split even though it is more verbose. I think it makes the module relationships more humanly clear.
Attachment #86570 - Flags: review+
Comment on attachment 86570 [details] [diff] [review] Patch to split liveconnect off from the java module. what garret said. sr=alecf
Comment on attachment 86570 [details] [diff] [review] Patch to split liveconnect off from the java module. a=asa (on behalf of drivers) for checkin to the 1.1 trunk.
Attachment #86570 - Flags: approval+
Status: NEW → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
To Dharma for verification
QA Contact: mdunn → dsirnapalli
mcafee, How do i verify this bug. Lot of the files have changed now. all.dot is no longer there. What is the best way to verify this.
this is a code-level change, I don't think we need v= here.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.