Closed
Bug 1453479
Opened 6 years ago
Closed 6 years ago
More updates for dark theme styles
Categories
(Firefox :: New Tab Page, defect, P2)
Firefox
New Tab Page
Tracking
()
Tracking | Status | |
---|---|---|
firefox61 | --- | verified |
People
(Reporter: rrosario, Assigned: rrosario)
References
Details
Attachments
(1 file)
There is another set of changes from Amy. See https://mozilla.invisionapp.com/share/H4FW3RYFXVK#/screens/279681634/comments/96091911 * Search box Search Box Fill: Grey 70 Active Border: Blue 40 Drop Shadow: Grey 90, Offset Y-Axis 1, Blur 4, Opacity 20% * Search dropdown See spec. Can you also double check the width of this search bar? It should be the width of top sites (I noticed that the left edge of topsites was peeking from behind the bar. Also the search results container should be just below search bar (I think there's a bit of overlap currently) * Top Sites Top Sites should have the same box drop-shadow as highlight/pocket cards * Top Site form input[type=text]:focus Remove extra blue border outline Active Border: Blue 40 * Modal (Edit Top Site, etc) Background Fill: Grey 80 Border: Grey 10, 10% Opacity * Pocket topic links Make them bold * Cards Background Fill: Grey 70 Hairline: Grey 10, Opacity 10% Card Box Shadow: Offset 1px, Blur 8px, Opacity 20% Check weight of font for titles. Should be Medium and not Bold. * Context Menu See spec
Assignee | ||
Updated•6 years ago
|
Assignee: nobody → rrosario
Iteration: --- → 61.3 - Apr 23
Comment 1•6 years ago
|
||
Comment 2•6 years ago
|
||
Commits pushed to master at https://github.com/mozilla/activity-stream https://github.com/mozilla/activity-stream/commit/180d534bb7148a1a9ae0f53310240c2168ebc24f Fix Bug 1453479 - more dark theme updates https://github.com/mozilla/activity-stream/commit/030284a413a8ad4435bc6a0599678c6bb93e9c69 Merge pull request #4087 from rlr/Bug1453479/dark-theme-updates Fix Bug 1453479 - more dark theme updates
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Comment 3•6 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/9896401414cb
status-firefox61:
--- → fixed
Target Milestone: --- → Firefox 61
Comment 4•6 years ago
|
||
The issue is no longer reproducible on the latest Nightly 61.0a1 on Windows 10, Mac 10.12.6 and Arch Linux x64.
Updated•5 years ago
|
Component: Activity Streams: Newtab → New Tab Page
You need to log in
before you can comment on or make changes to this bug.
Description
•