Closed Bug 1453503 Opened 6 years ago Closed 5 years ago

Clean up permissions code in extensions/

Categories

(Core :: Permission Manager, enhancement, P3)

Product:
Core
Component:
Permission Manager
Type:
enhancement

Tracking

()

Status:
RESOLVED WORKSFORME

People

(Reporter: qdot, Unassigned)

Details

The permissions manager currently lives in extensions/cookie but could be moved to dom/permissions, and there's other permissions code in extensions that's either unused or can be moved.
Assignee: nobody → kyle
Priority: -- → P3
Hm, do you want to move it to dom/permissions or dom/permission? Technically I don't think permissions is a DOM thing, to be honest, so my vote would be for keeping it somewhere else. dom/permission holds the (incomplete) DOM permission API which isn't fully standardized/agreed on yet (https://github.com/mozilla/standards-positions/issues/19), so I'm not sure that directory is perfect either...

I don't feel strongly about this, though.
My reasoning was that the DOM Permissions API uses nsPermissionManager, so it'd be ok for us to centralize everything in dom/permissions, but it doesn't really "fit" for the cookie stuff (not that nsPermissionManager "fits" in the cookie directory well either). I was mostly just surprised that it was in extensions/cookie.
Assignee: kyle → nobody

I think this is actually resolved as of bug 1547397...

Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.