Closed Bug 1453545 Opened 6 years ago Closed 6 years ago

"Properties" option disabled when right-clicking folder in bookmarks toolbar

Categories

(Firefox :: Bookmarks & History, defect, P1)

61 Branch
defect

Tracking

()

VERIFIED FIXED
Firefox 61
Tracking Status
firefox-esr52 --- unaffected
firefox59 --- unaffected
firefox60 --- unaffected
firefox61 + verified

People

(Reporter: ssj2kite, Assigned: mak)

References

Details

(Keywords: regression, Whiteboard: [fxsearch])

Attachments

(1 file)

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:61.0) Gecko/20100101 Firefox/61.0
Build ID: 20180412001050

Steps to reproduce:

Show the bookmarks toolbar, make a folder if you don't have one already, and right click.


Actual results:

The "Properties" option is grayed out, despite having 2 editable properties (Name and Description.)


Expected results:

It shouldn't be grayed out. Name and Description are still accessible and editable via the Library window.  Mozregression points to bug #1452621.
The issue is reproducible on Nightly 61.0a1 (2018-04-16), Windows 10.0 x64.

I could not reproduce on Firefox 59.0.2 and 60.0b12.

Based on comment 0, the bug is regressed by bug 1452621.
Status: UNCONFIRMED → NEW
Component: Untriaged → Bookmarks & History
Ever confirmed: true
Keywords: regression
Blocks: 1452621
Priority: -- → P1
Whiteboard: [fxsearch]
yeah the nodeIsBookmark is not enough, should also check nodeIsFolder
Assignee: nobody → mak77
Status: NEW → ASSIGNED
Attachment #8969101 - Flags: review?(standard8)
Comment on attachment 8969101 [details]
Bug 1453545 - Properties option disabled when right-clicking a bookmarks folder.

https://reviewboard.mozilla.org/r/237798/#review243696

Looks great, r=Standard8
Attachment #8969101 - Flags: review?(standard8) → review+
Pushed by mak77@bonardo.net:
https://hg.mozilla.org/integration/autoland/rev/b0c68c179151
Properties option disabled when right-clicking a bookmarks folder. r=standard8
https://hg.mozilla.org/mozilla-central/rev/b0c68c179151
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 61
Blocks: 503693
I have reproduced this bug with Nightly 61.0a1 (2018-04-11) on Windows 10 , 64 Bit ! 

This bug's fix is Verified with latest Nightly !

Build   ID    20180423100754
User Agent    Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:61.0) Gecko/20100101 Firefox/61.0

[bugday-20180418]
I have reproduced this bug with Nightly 61.0a1 (2018-04-12) on Ubuntu 16.04 LTS!

This bug's fix is Verified with latest Nightly !

Build   ID - 20180424220100
User Agent - Mozilla/5.0 (X11; Linux x86_64; rv:61.0) Gecko/20100101 Firefox/61.0
QA Whiteboard: [bugday-20180425]
As par comment 8 & comment 9 , I am marking this bug as verified fixed !
Status: RESOLVED → VERIFIED
This issue was not fixed for "Most Visited" default smart bookmarks folder. It is still reproducible on the latest Nightly 62.0a1 (2018-06-13)- see screenshot: https://drive.google.com/open?id=1MXK0jPw_vDCuDFrqohvF2S_J8b17As7X . Bug 1452621 is also the cause for this behavior.
(In reply to Anca Soncutean [:Anca], Desktop Release QA from comment #11)
> This issue was not fixed for "Most Visited" default smart bookmarks folder.
> It is still reproducible on the latest Nightly 62.0a1 (2018-06-13)- see
> screenshot:
> https://drive.google.com/open?id=1MXK0jPw_vDCuDFrqohvF2S_J8b17As7X . Bug
> 1452621 is also the cause for this behavior.

That's either a wontfix or a UI coherency P5 bug; in the end there's nothing you can edit of a query, so the properties dialog is quite pointless there (no loss of functionality for the user)
Flags: in-qa-testsuite+
You need to log in before you can comment on or make changes to this bug.