Closed
Bug 1453565
Opened 6 years ago
Closed 6 years ago
[wpt-sync] Sync PR 10371 - [css-typed-om] Support remaining multi-col properties.
Categories
(Core :: DOM: CSS Object Model, enhancement, P4)
Core
DOM: CSS Object Model
Tracking
()
RESOLVED
FIXED
mozilla61
Tracking | Status | |
---|---|---|
firefox61 | --- | fixed |
People
(Reporter: mozilla.org, Unassigned)
References
()
Details
(Whiteboard: [wptsync downstream])
Sync web-platform-tests PR 10371 into mozilla-central (this bug is closed when the sync is complete). PR: https://github.com/w3c/web-platform-tests/pull/10371 Details from upstream follow. Darren Shen <shend@chromium.org> wrote: > [css-typed-om] Support remaining multi-col properties. > > To support column-count which takes <integer>s, we had implement integer > handling as resolved by: > https://github.com/w3c/css-houdini-drafts/issues/574#issuecomment-366845604 > > Basically, a non-integer passed to <integer> is 'out of range', so we > wrap it in a calc(). Coincidentally, column-count also needs to be > positive, so we had to change ComputedStyle::SetColumnCount to clamp. > Note that this doesn't change CSSOM behaviour, as the parser > would've rejected non-positive values so ComputedStyle only gets > positive values. Since Typed OM skips parsing, we have to clamp in > ComputedStyle as well. > > Bug: 820299 > Change-Id: Ia56e4bdb55826e72d46c66666addda168dea3d2a > Reviewed-on: https://chromium-review.googlesource.com/1001084 > Reviewed-by: Rune Lillesveen <futhark@chromium.org> > Commit-Queue: Darren Shen <shend@chromium.org> > Cr-Commit-Position: refs/heads/master@{#550058} > > >
Reporter | ||
Updated•6 years ago
|
Component: web-platform-tests → DOM: CSS Object Model
Product: Testing → Core
Reporter | ||
Comment 1•6 years ago
|
||
Pushed to try https://treeherder.mozilla.org/#/jobs?repo=try&revision=fbef7280e773a1f54622d454f9246f750b7b48e8
Reporter | ||
Comment 2•6 years ago
|
||
Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=d4a2d73cf4ca3ce0b397dfdd0f374a08a6d3441f
Reporter | ||
Comment 3•6 years ago
|
||
Ran 3 tests and 3 subtests OK : 3 FAIL : 3 New tests that have failures or other problems: /css/css-typed-om/the-stylepropertymap/properties/column-count.html 'column-count' property: FAIL /css/css-typed-om/the-stylepropertymap/properties/column-rule-style.html 'column-rule-style' property: FAIL /css/css-typed-om/the-stylepropertymap/properties/column-rule-width.html 'column-rule-width' property: FAIL
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/52d9682a524c [wpt PR 10371] - [css-typed-om] Support remaining multi-col properties., a=testonly https://hg.mozilla.org/integration/mozilla-inbound/rev/9775b44cb66f [wpt PR 10371] - Update wpt metadata, a=testonly
Comment 5•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/52d9682a524c https://hg.mozilla.org/mozilla-central/rev/9775b44cb66f
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox61:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
You need to log in
before you can comment on or make changes to this bug.
Description
•