1453589 - Usability loss in managing Cookies in Firefox 60

Status: VERIFIED FIXED

(Firefox :: Settings UI, defect, P1)

Description

[Bob Clary [:bc] (inactive)]

1. Open Preferences
2. Choose Privacy & Security
3. Select Manage Data under Cookies and Site Data
4. Select Cookie to be removed.
5. Click Remove Selected
6. The next site is not selected/highlighted.

In Firefox 59 and earlier the next site in the list would remain selected so that you could delete the next site by simply clicking Remove Selected again.

In Firefox 60, the selection is lost which requires you to click on the next site before clicking Remove Selected again.

This makes it a major PITA to review and delete unwanted cookies.

Once a site is selected and removed, the next site in the list should be selected so that the user can easily delete the next site in the list.

Allowing multiple selections would also be good, but would not replace the effectiveness of the previous behavior.

Comment 1

[Johann Hofmann [:johannh]]

Yeah, I'm not sure what the best behavior would be here. FWIW, I just fixed multi-select with bug 1442183 and we could try to uplift that to 60.

We'll take a look at this.

Comment 2

[Johann Hofmann [:johannh]]

Not sure whether this should really be a tracking issue for 60, but I filed for uplift in https://bugzilla.mozilla.org/show_bug.cgi?id=1442183#c9 which should help a ton with the usability, no matter what we decide to do in this bug (and when).

Comment 3

[Michael Kohler [:mkohler]]

Happy to help out here as I've broken the UX here ;) Please n-i me once there is a decision on what to do here.

Comment 4

[Johann Hofmann [:johannh]]

(In reply to Michael Kohler [:mkohler] from comment #3)
> Happy to help out here as I've broken the UX here ;) Please n-i me once
> there is a decision on what to do here.

I'll get ahead of triage meeting on Tuesday and say that we should probably just select the next website, since we explicitly warn the user of which websites are going to be deleted afterwards (so there shouldn't be much risk of accidentally deleting too much data).

Feel free to work on this, I'm happy to help if you need any :)

Thank you!

Comment 5

[Julien Cristau [:jcristau]]

fix-optional for 60 based on comment 2.

Comment 6

[Phabricator Automation]

Attachment: Bug 1453589 - Select next item in list when removing items in Site Data Manager r=johannh

Select next item in list when removing items in Site Data Manager. When there are multiple selected sites, it will select the next item after the last previously selected item.

Comment 7

[Johann Hofmann [:johannh]]

Thanks for the patch! That phabricator bridge isn't working particularly well... I'll review this later today

Comment 8

[Phabricator Automation]

Comment on attachment 8968673 [details]
Bug 1453589 - Select next item in list when removing items in Site Data Manager r=johannh

Johann Hofmann [:johannh] has approved the revision.

https://phabricator.services.mozilla.com/D965

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/525f1fb9501e
Select next item in list when removing items in Site Data Manager. r=johannh

Comment 10

[Eliza Balazs [:ebalazs_]]

Backed out changeset 525f1fb9501e (bug 1453589) for ES lint failure in /builds/worker/checkouts/gecko/browser/components/preferences/in-content/tests/siteData/head.js

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=525f1fb9501e36f69a8d5b7fbfbeb62335ec6d73&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=runnable&filter-resultStatus=success&selectedJob=174542169

Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=174542169&repo=mozilla-inbound&lineNumber=257

Backout: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=268e499a9da807f3eb9a11ae14a10c68184b5b77&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=runnable&filter-resultStatus=success

Comment 11

[Michael Kohler [:mkohler]]

I've fixed the error. Setting checkin-needed again. Sorry about that.

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/7c588027cbbb
Select next item in list when removing items in Site Data Manager. r=johannh

Comment 13

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/7c588027cbbb

Comment 14

[Bob Clary [:bc] (inactive)]

This is much better. Thank you.

Comment 15

[Ryan VanderMeulen [:RyanVM]]

We built the Fx60 RC build today, so calling this too late for uplift consideration.

Comment 16

[Gabi Cheta [:Gabi] Desktop QA]

Verified as fixed with 61.0b9 on Ubuntu 14.4, MacOS 10.13 and Windows 10x64.