Closed Bug 1453634 Opened 6 years ago Closed 6 years ago

Linux and Windows opt bustage due to webcompat-reporter when Gecko 61 merges to Beta on 2018-04-26

Categories

(Web Compatibility :: Tooling & Investigations, defect, P1)

defect

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: aryx, Assigned: miketaylr)

References

Details

Attachments

(1 file, 3 obsolete files)

Most likely a regression from bug 1409056.

central-as-beta simulation: https://treeherder.mozilla.org/#/jobs?repo=try&revision=4e12973294f4adfd71e5920515340e6a21c8f9a4&group_state=expanded&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=retry&filter-resultStatus=usercancel&filter-resultStatus=runnable

There is no green Windows opt build yet, they are still running.

If you want to test it on Try, apply those 3 patches from above mentioned Try push.

Build log: https://treeherder.mozilla.org/logviewer.html#?job_id=173245064&repo=try

task 2018-04-12T12:39:33.546Z] 12:39:33     INFO -  make[6]: Entering directory '/builds/worker/workspace/build/src/obj-firefox/browser/locales'
[task 2018-04-12T12:39:33.547Z] 12:39:33     INFO -  /builds/worker/workspace/build/src/obj-firefox/_virtualenv/bin/python /builds/worker/workspace/build/src/toolkit/mozapps/installer/l10n-repack.py '/builds/worker/workspace/build/src/obj-firefox/dist/l10n-stage/firefox' ../../dist/xpi-stage/locale-x-test \
[task 2018-04-12T12:39:33.547Z] 12:39:33     INFO -  	 \
[task 2018-04-12T12:39:33.547Z] 12:39:33     INFO -  Error: Locale doesn't contain browser/features/webcompat-reporter@mozilla.org/
[task 2018-04-12T12:39:33.547Z] 12:39:33     INFO -  Traceback (most recent call last):
[task 2018-04-12T12:39:33.547Z] 12:39:33     INFO -    File "/builds/worker/workspace/build/src/toolkit/mozapps/installer/l10n-repack.py", line 60, in <module>
[task 2018-04-12T12:39:33.547Z] 12:39:33     INFO -      main()
[task 2018-04-12T12:39:33.547Z] 12:39:33     INFO -    File "/builds/worker/workspace/build/src/toolkit/mozapps/installer/l10n-repack.py", line 56, in main
[task 2018-04-12T12:39:33.548Z] 12:39:33     INFO -      non_resources=args.non_resource, non_chrome=NON_CHROME)
[task 2018-04-12T12:39:33.548Z] 12:39:33     INFO -    File "/builds/worker/workspace/build/src/python/mozbuild/mozpack/packager/l10n.py", line 276, in repack
[task 2018-04-12T12:39:33.548Z] 12:39:33     INFO -      _repack(app_finder, l10n_finder, copier, formatter, non_chrome)
[task 2018-04-12T12:39:33.548Z] 12:39:33     INFO -    File "/usr/lib/python2.7/contextlib.py", line 24, in __exit__
[task 2018-04-12T12:39:33.548Z] 12:39:33     INFO -      self.gen.next()
[task 2018-04-12T12:39:33.548Z] 12:39:33     INFO -    File "/builds/worker/workspace/build/src/python/mozbuild/mozpack/errors.py", line 131, in accumulate
[task 2018-04-12T12:39:33.549Z] 12:39:33     INFO -      raise AccumulatedErrors()
[task 2018-04-12T12:39:33.549Z] 12:39:33     INFO -  mozpack.errors.AccumulatedErrors
[task 2018-04-12T12:39:33.549Z] 12:39:33     INFO -  /builds/worker/workspace/build/src/toolkit/locales/l10n.mk:116: recipe for target 'repackage-zip' failed
[task 2018-04-12T12:39:33.549Z] 12:39:33     INFO -  make[6]: *** [repackage-zip] Error 1
Flags: needinfo?(miket)
Summary: Linux opt bustage due to webcompat-reporter when Gecko 61 merges to Beta on 2018-04-26 → Linux and Windows opt bustage due to webcompat-reporter when Gecko 61 merges to Beta on 2018-04-26
Assignee: nobody → miket
Flags: needinfo?(miket)
Priority: -- → P1
Arf, thanks and sorry.
Attachment #8967472 - Attachment is obsolete: true
Attachment #8967473 - Attachment is obsolete: true
Attachment #8967474 - Attachment is obsolete: true
(In reply to Mike Taylor [:miketaylr] from comment #6)
> https://treeherder.mozilla.org/#/
> jobs?repo=try&revision=2f34db686ec565d53f490a74576c97e06381d4c9

Try push proves Linux and Windows opt can build with this patch.
Comment on attachment 8967471 [details]
Bug 1453634. Make webcompat-reporter l10n work when it hits beta.

https://reviewboard.mozilla.org/r/236134/#review241988
Attachment #8967471 - Flags: review?(florian) → review+
Comment on attachment 8967471 [details]
Bug 1453634. Make webcompat-reporter l10n work when it hits beta.

https://reviewboard.mozilla.org/r/236134/#review241988

thanks for review!
Pushed by mitaylor@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/15332e1d2eda
Make webcompat-reporter l10n work when it hits beta. r=florian
https://hg.mozilla.org/mozilla-central/rev/15332e1d2eda
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.