145367 - use nspr's base64 code in the LDIF import code, instead of having our own implementation

Status: NEW

(MailNews Core :: Import, defect)

Description

[(not reading, please use [e-mail] instead)]

use nspr's base64 code in the LDIF import code, instead of having our own 
implementation

see nsTextAddress.cpp

// XXX TODO fix me
// use the NSPR base64 library.  see plbase64.h

Comment 1

[(not reading, please use [e-mail] instead)]

this is low priority, code cleanup.

Comment 2

[Dan Mosedale (:dmosedale, :dmose)]

Another possible approach might be to use the LDAP C SDK code for reading and
writing LDIF format stuff.  This would perhaps involve adding an interface or
two  to the LDAP XPCOM SDK, but that shouldn't be hard, or perhaps just linking
statically with libldif.  The C SDK functions are defined here:

http://lxr.mozilla.org/mozilla/source/directory/c-sdk/ldap/include/ldif.h
http://lxr.mozilla.org/mozilla/source/directory/c-sdk/ldap/libraries/libldif/line64.c

Comment 3

[Mark Smith [:mcs]]

And in case someone asks: the libldif code does not use NSPR's base64
encode/decode functions because:

1) The code pre-dates NSPR to some extent.

2) I didn't know NSPR had that functionality.

3) There is still a desire from some users of libldap to not have it depend on
NSPR. But I don't think libldap uses libldif so this is not important (the LDAP
command line utilities under ldap/clients/tools do use libldap).