1453701 - Land 30fps and 20fps configurations for the tab loading throbbers

Status: RESOLVED FIXED

(Firefox :: Theme, enhancement)

Description

[Mike Conley (:mconley) (:⚙️)]

We'd like to test the hypothesis that 30fps or 20fps tab loading throbbers will positively impact page load time for some set of our users. This bug is to land those configurations.

Comment 1

[Mike Conley (:mconley) (:⚙️)]

Attachment: 20fps SVG

Comment 2

[Mike Conley (:mconley) (:⚙️)]

Attachment: 30fps SVG

Comment 3

[u614034]

(In reply to Mike Conley (:mconley) (:⚙️) (Totally backlogged on reviews and needinfos) from comment #0)
> We'd like to test the hypothesis that 30fps or 20fps tab loading throbbers
> will positively impact page load time for some set of our users. This bug is
> to land those configurations.

would this be available on windows and Linux as well?
Any test builds?

Comment 4

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1453701 - Add 30fps and 20fps configurations for the tab loading throbber.

Review commit: https://reviewboard.mozilla.org/r/236118/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/236118/

Comment 5

[Mike Conley (:mconley) (:⚙️)]

(In reply to Emilio from comment #3)
> would this be available on windows and Linux as well?

I expect this to be cross-platform, yes.

> Any test builds?

Not yet - but it should be in Nightly not long after the patches from this bug land.

Comment 6

[Mike Conley (:mconley) (:⚙️)]

So I expected this to be rather simple, and (as usual) that expectation wasn't in line with reality. With the patch as it is, I get a strange "strobe-ing" effect, and the bouncing appears to be quite fast. Also, the 20fps throbber has a black fill colour. I'm not sure what the story is there.

jaws, I might need some help here, since you've worked with this sort of thing before... what am I doing wrong?

Comment 7

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 8967453 [details]
Bug 1453701 - Add 30fps and 20fps configurations for the tab loading throbber.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/236118/diff/1-2/

Comment 8

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8967453 [details]
Bug 1453701 - Add 30fps and 20fps configurations for the tab loading throbber.

https://reviewboard.mozilla.org/r/236118/#review241924

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d0392a55774b
Add 30fps and 20fps configurations for the tab loading throbber. r=jaws

Comment 10

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/d0392a55774b

Comment 11

[Jason Mechelynck]

can this be uplifted to Firefox 60 please?

Comment 12

[Jared Wein [:jaws] (please needinfo? me)]

We aren't planning on uplifting this to Firefox 60 as we are planning on using this to run studies to find which version works best for users. Would you be able to run Firefox Nightly in the meantime? This will get released to Firefox Beta and Firefox Developer Edition on May 9th.

Comment 13

[Jason Mechelynck]

(In reply to Jared Wein [:jaws] (please needinfo? me) from comment #12)
> We aren't planning on uplifting this to Firefox 60 as we are planning on
> using this to run studies to find which version works best for users. Would
> you be able to run Firefox Nightly in the meantime? This will get released
> to Firefox Beta and Firefox Developer Edition on May 9th.

OK but in our offices we have ESR only policy so on't get the benefits there,
any chance of a uplift since its a month away from release?

where can one find the study and the results?

Comment 14

[Jared Wein [:jaws] (please needinfo? me)]

Mike would be a better person to answer that.

Comment 15

[Mike Conley (:mconley) (:⚙️)]

(In reply to Jason Mechelynck from comment #13)
> OK but in our offices we have ESR only policy so on't get the benefits there,
> any chance of a uplift since its a month away from release?
> 

No, I don't believe so. The earliest the study will take place is on 61, particularly because it's blocked on bug 1454324, which is coming along, but will likely arrive too late for an uplift to 60.

> where can one find the study and the results?

The study has not yet been started due to bug 1454324 still being in flight. The study is still in the midst of being defined and approved by our data / privacy / experiment peers.

Comment 16

[Jason Mechelynck]

Mike Conley (:mconley) & Jared Wein [:jaws]

One more

Any pref to only use old one(circling one) only
and the new one png version? only

It would also give a better view of performance vs SVg ones which is causing slowdowns

Comment 17

[Mike Conley (:mconley) (:⚙️)]

(In reply to Jason Mechelynck from comment #16)
> Mike Conley (:mconley) & Jared Wein [:jaws]
> 

Hi Jason,

No, no such pref exists at this time, and I believe we're unlikely to add one, as we're attempting to pull most GIF and PNG graphics out of the product (bug 1450569).