Closed
Bug 1453702
Opened 6 years ago
Closed 6 years ago
Assertion failure: !needsFrameBitSet (Ancestors of nodes with frames to be constructed lazily should not have NEEDS_FRAME bit set), at /builds/worker/workspace/build/src/layout/base/nsCSSFrameConstructor.cpp:6840
Categories
(Core :: Layout, defect)
Tracking
()
RESOLVED
FIXED
mozilla61
Tracking | Status | |
---|---|---|
firefox-esr52 | --- | unaffected |
firefox59 | --- | unaffected |
firefox60 | --- | unaffected |
firefox61 | --- | fixed |
People
(Reporter: jkratzer, Assigned: emilio)
References
(Blocks 1 open bug)
Details
(Keywords: assertion, testcase)
Attachments
(3 files, 1 obsolete file)
Testcase found while fuzzing mozilla-central rev f6c3a0a19d82. rax = 0x0000000000000000 rdx = 0x0000000000000000 rcx = 0x00007fe47271d2dd rbx = 0x0000000000000000 rsi = 0x00007fe4729ec770 rdi = 0x00007fe4729eb540 rbp = 0x00007fff1744e690 rsp = 0x00007fff1744e670 r8 = 0x00007fe4729ec770 r9 = 0x00007fe473ab6740 r10 = 0x0000000000000039 r11 = 0x0000000000000000 r12 = 0x0000000000000001 r13 = 0x0000000000000000 r14 = 0x00007fe4518ae200 r15 = 0x00007fe4518c54c0 rip = 0x00007fe462a305b1 OS|Linux|0.0.0 Linux 4.4.0-119-generic #143-Ubuntu SMP Mon Apr 2 16:08:24 UTC 2018 x86_64 CPU|amd64|family 6 model 78 stepping 3|1 GPU||| Crash|SIGSEGV|0x0|0 0|0|libxul.so|nsCSSFrameConstructor::CheckBitsForLazyFrameConstruction|hg:hg.mozilla.org/mozilla-central:layout/base/nsCSSFrameConstructor.cpp:f6c3a0a19d82db25750d8badccd5cf37e79d028e|6839|0x18 0|1|libxul.so|nsCSSFrameConstructor::MaybeConstructLazily|hg:hg.mozilla.org/mozilla-central:layout/base/nsCSSFrameConstructor.cpp:f6c3a0a19d82db25750d8badccd5cf37e79d028e|6912|0xb 0|2|libxul.so|nsCSSFrameConstructor::ContentAppended|hg:hg.mozilla.org/mozilla-central:layout/base/nsCSSFrameConstructor.cpp:f6c3a0a19d82db25750d8badccd5cf37e79d028e|7117|0x11 0|3|libxul.so|mozilla::PresShell::ContentAppended|hg:hg.mozilla.org/mozilla-central:layout/base/PresShell.cpp:f6c3a0a19d82db25750d8badccd5cf37e79d028e|4480|0x11 0|4|libxul.so|nsNodeUtils::ContentAppended|hg:hg.mozilla.org/mozilla-central:dom/base/nsNodeUtils.cpp:f6c3a0a19d82db25750d8badccd5cf37e79d028e|192|0xc 0|5|libxul.so|nsINode::doInsertChildAt|hg:hg.mozilla.org/mozilla-central:dom/base/nsINode.cpp:f6c3a0a19d82db25750d8badccd5cf37e79d028e|1367|0x8 0|6|libxul.so|nsINode::ReplaceOrInsertBefore|hg:hg.mozilla.org/mozilla-central:dom/base/nsINode.cpp:f6c3a0a19d82db25750d8badccd5cf37e79d028e|2257|0x1b 0|7|libxul.so|mozilla::dom::NodeBinding::appendChild|hg:hg.mozilla.org/mozilla-central:dom/base/nsINode.h:f6c3a0a19d82db25750d8badccd5cf37e79d028e|1821|0x12 0|8|libxul.so|mozilla::dom::binding_detail::GenericMethod<mozilla::dom::binding_detail::NormalThisPolicy, mozilla::dom::binding_detail::ThrowExceptions>|hg:hg.mozilla.org/mozilla-central:dom/bindings/BindingUtils.cpp:f6c3a0a19d82db25750d8badccd5cf37e79d028e|3191|0x9 0|9|libxul.so|js::CallJSNative|hg:hg.mozilla.org/mozilla-central:js/src/vm/JSContext-inl.h:f6c3a0a19d82db25750d8badccd5cf37e79d028e|290|0x6 0|10|libxul.so|js::InternalCallOrConstruct|hg:hg.mozilla.org/mozilla-central:js/src/vm/Interpreter.cpp:f6c3a0a19d82db25750d8badccd5cf37e79d028e|467|0xf 0|11|libxul.so|InternalCall|hg:hg.mozilla.org/mozilla-central:js/src/vm/Interpreter.cpp:f6c3a0a19d82db25750d8badccd5cf37e79d028e|516|0xd 0|12|libxul.so|Interpret|hg:hg.mozilla.org/mozilla-central:js/src/vm/Interpreter.cpp:f6c3a0a19d82db25750d8badccd5cf37e79d028e|522|0xf 0|13|libxul.so|js::RunScript|hg:hg.mozilla.org/mozilla-central:js/src/vm/Interpreter.cpp:f6c3a0a19d82db25750d8badccd5cf37e79d028e|417|0xb 0|14|libxul.so|js::InternalCallOrConstruct|hg:hg.mozilla.org/mozilla-central:js/src/vm/Interpreter.cpp:f6c3a0a19d82db25750d8badccd5cf37e79d028e|489|0xf 0|15|libxul.so|InternalCall|hg:hg.mozilla.org/mozilla-central:js/src/vm/Interpreter.cpp:f6c3a0a19d82db25750d8badccd5cf37e79d028e|516|0xd 0|16|libxul.so|js::Call|hg:hg.mozilla.org/mozilla-central:js/src/vm/Interpreter.cpp:f6c3a0a19d82db25750d8badccd5cf37e79d028e|535|0x5 0|17|libxul.so|JS::Call|hg:hg.mozilla.org/mozilla-central:js/src/jsapi.cpp:f6c3a0a19d82db25750d8badccd5cf37e79d028e|3003|0x20 0|18|libxul.so|mozilla::dom::EventListener::HandleEvent|s3:gecko-generated-sources:ccbadb8791154c00d5d9f3f34300a418cdfa4b3b0b60424e60394883162a95118b3edbfce81cbc7a5b48193d5a2618fc449143e250bd5c61dd1340709a3af189/dom/bindings/EventListenerBinding.cpp:|51|0x5 0|19|libxul.so|mozilla::dom::EventListener::HandleEvent<mozilla::dom::EventTarget*>|s3:gecko-generated-sources:0502cca494d7ae0441ada14535523caade9340fdd09934cf6d31cc421267c319ae3d6f5b43b2730d0b36ae1c87480f3b426c5fa4fec57d51047d83a51acde602/dist/include/mozilla/dom/EventListenerBinding.h:|66|0x1c 0|20|libxul.so|mozilla::EventListenerManager::HandleEventSubType|hg:hg.mozilla.org/mozilla-central:dom/events/EventListenerManager.cpp:f6c3a0a19d82db25750d8badccd5cf37e79d028e|1120|0x36 0|21|libxul.so|mozilla::EventListenerManager::HandleEventInternal|hg:hg.mozilla.org/mozilla-central:dom/events/EventListenerManager.cpp:f6c3a0a19d82db25750d8badccd5cf37e79d028e|1292|0x19 0|22|libxul.so|mozilla::EventTargetChainItem::HandleEvent|hg:hg.mozilla.org/mozilla-central:dom/events/EventListenerManager.h:f6c3a0a19d82db25750d8badccd5cf37e79d028e|378|0xa 0|23|libxul.so|mozilla::EventTargetChainItem::HandleEventTargetChain|hg:hg.mozilla.org/mozilla-central:dom/events/EventDispatcher.cpp:f6c3a0a19d82db25750d8badccd5cf37e79d028e|527|0xf 0|24|libxul.so|mozilla::EventDispatcher::Dispatch|hg:hg.mozilla.org/mozilla-central:dom/events/EventDispatcher.cpp:f6c3a0a19d82db25750d8badccd5cf37e79d028e|934|0xb 0|25|libxul.so|mozilla::EventDispatcher::DispatchDOMEvent|hg:hg.mozilla.org/mozilla-central:dom/events/EventDispatcher.cpp:f6c3a0a19d82db25750d8badccd5cf37e79d028e|1016|0x19 0|26|libxul.so|nsINode::DispatchEvent|hg:hg.mozilla.org/mozilla-central:dom/base/nsINode.cpp:f6c3a0a19d82db25750d8badccd5cf37e79d028e|1084|0x5 0|27|libxul.so|nsContentUtils::DispatchEvent|hg:hg.mozilla.org/mozilla-central:dom/base/nsContentUtils.cpp:f6c3a0a19d82db25750d8badccd5cf37e79d028e|4480|0x28 0|28|libxul.so|nsContentUtils::DispatchTrustedEvent|hg:hg.mozilla.org/mozilla-central:dom/base/nsContentUtils.cpp:f6c3a0a19d82db25750d8badccd5cf37e79d028e|4449|0xf 0|29|libxul.so|nsIDocument::DispatchContentLoadedEvents|hg:hg.mozilla.org/mozilla-central:dom/base/nsDocument.cpp:f6c3a0a19d82db25750d8badccd5cf37e79d028e|5221|0x5 0|30|libxul.so|mozilla::detail::RunnableMethodImpl<nsIDocument*, void (nsIDocument::*)(), true, (mozilla::RunnableKind)0u>::Run|hg:hg.mozilla.org/mozilla-central:xpcom/threads/nsThreadUtils.h:f6c3a0a19d82db25750d8badccd5cf37e79d028e|1164|0x13 0|31|libxul.so|mozilla::SchedulerGroup::Runnable::Run|hg:hg.mozilla.org/mozilla-central:xpcom/threads/SchedulerGroup.cpp:f6c3a0a19d82db25750d8badccd5cf37e79d028e|337|0x15 0|32|libxul.so|nsThread::ProcessNextEvent|hg:hg.mozilla.org/mozilla-central:xpcom/threads/nsThread.cpp:f6c3a0a19d82db25750d8badccd5cf37e79d028e|1096|0x15 0|33|libxul.so|NS_ProcessNextEvent|hg:hg.mozilla.org/mozilla-central:xpcom/threads/nsThreadUtils.cpp:f6c3a0a19d82db25750d8badccd5cf37e79d028e|519|0x11 0|34|libxul.so|mozilla::ipc::MessagePump::Run|hg:hg.mozilla.org/mozilla-central:ipc/glue/MessagePump.cpp:f6c3a0a19d82db25750d8badccd5cf37e79d028e|97|0xa 0|35|libxul.so|MessageLoop::RunInternal|hg:hg.mozilla.org/mozilla-central:ipc/chromium/src/base/message_loop.cc:f6c3a0a19d82db25750d8badccd5cf37e79d028e|326|0x17 0|36|libxul.so|MessageLoop::Run|hg:hg.mozilla.org/mozilla-central:ipc/chromium/src/base/message_loop.cc:f6c3a0a19d82db25750d8badccd5cf37e79d028e|319|0x8 0|37|libxul.so|nsBaseAppShell::Run|hg:hg.mozilla.org/mozilla-central:widget/nsBaseAppShell.cpp:f6c3a0a19d82db25750d8badccd5cf37e79d028e|157|0xd 0|38|libxul.so|XRE_RunAppShell|hg:hg.mozilla.org/mozilla-central:toolkit/xre/nsEmbedFunctions.cpp:f6c3a0a19d82db25750d8badccd5cf37e79d028e|893|0x11 0|39|libxul.so|mozilla::ipc::MessagePumpForChildProcess::Run|hg:hg.mozilla.org/mozilla-central:ipc/glue/MessagePump.cpp:f6c3a0a19d82db25750d8badccd5cf37e79d028e|269|0x5 0|40|libxul.so|MessageLoop::RunInternal|hg:hg.mozilla.org/mozilla-central:ipc/chromium/src/base/message_loop.cc:f6c3a0a19d82db25750d8badccd5cf37e79d028e|326|0x17 0|41|libxul.so|MessageLoop::Run|hg:hg.mozilla.org/mozilla-central:ipc/chromium/src/base/message_loop.cc:f6c3a0a19d82db25750d8badccd5cf37e79d028e|319|0x8 0|42|libxul.so|XRE_InitChildProcess|hg:hg.mozilla.org/mozilla-central:toolkit/xre/nsEmbedFunctions.cpp:f6c3a0a19d82db25750d8badccd5cf37e79d028e|719|0x8 0|43|firefox|content_process_main|hg:hg.mozilla.org/mozilla-central:ipc/contentproc/plugin-container.cpp:f6c3a0a19d82db25750d8badccd5cf37e79d028e|50|0x14 0|44|firefox|main|hg:hg.mozilla.org/mozilla-central:browser/app/nsBrowserApp.cpp:f6c3a0a19d82db25750d8badccd5cf37e79d028e|280|0x11 0|45|libc-2.23.so||||0x20830
Flags: in-testsuite?
Assignee | ||
Updated•6 years ago
|
Flags: needinfo?(emilio)
Assignee | ||
Comment 1•6 years ago
|
||
"Foo" shouldn't be seen per spec. This happens because <textarea> is one of those elements which behaves at display: none when they have display: contents. We get confused because we think it's display: contents when computing an insertion point, and show it instead. I propose changing this to compute as display none instead, which is what other browser engines do, and simplifies a lot of other stuff.
Assignee | ||
Updated•6 years ago
|
Attachment #8967969 -
Attachment mime type: text/plain → text/html
Flags: needinfo?(emilio)
Assignee | ||
Updated•6 years ago
|
Assignee: nobody → emilio
Comment hidden (mozreview-request) |
Assignee | ||
Comment 4•6 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=ce313b09d83188fcbd6fc7a323c2c305bc23936f (Ignore the reftest failure, since I forgot to include the test file in that try push. I promise it passes :P)
Comment hidden (mozreview-request) |
Comment 6•6 years ago
|
||
mozreview-review |
Comment on attachment 8967987 [details] Bug 1453702: [css-display] Move unboxing to style, and handle display: contents before other suppressions. https://reviewboard.mozilla.org/r/236674/#review242470 r- because this patch breaks the following testcase: <details> <div style="display:contents; color:blue"> <summary>summary</summary> details </div> </details> ::: commit-message-7aad6:1 (Diff revision 2) > +Bug 1453702: [css-display] Move unboxing to style, and handle display: contents before other suppresions. r?mats > + typo: s/suppresions/suppressions/ ::: commit-message-7aad6:9 (Diff revision 2) > +support display: contents until a use case appears. > + > +This makes our behavior consistent both with the spec and also in terms of > +handling dynamic changes to stuff that would otherwise get suppressed. > + > +Also makes us consistent with both Blink and WebKit in terms of computed style. nit: as far as I know, Blink and WebKit share the same style system and layout code for the most part. I think "Blink and WebKit" implies that they should be thought of as separate independent UAs. I disagree; I think they should be viewed as one CSS implementation (and count as one UA in that respect), so I think "Blink/WebKit" is a better term here. ::: commit-message-7aad6:16 (Diff revision 2) > +computing to display: none. Will file a spec issue to get that changed. > + > +It also makes us match Blink and WebKit in terms of respecting display: contents > +before other suppressions, see the reftest which I didn't write as a WPT > +(because there's no spec supporting neither that or the opposite of what we do), > +where a <g> element respects display contents even though if it had any other nit: s/display contents/display: contents/
Attachment #8967987 -
Flags: review?(mats) → review-
Comment 7•6 years ago
|
||
You should get someone else to also review the Rust bits.
Assignee | ||
Comment 8•6 years ago
|
||
(In reply to Mats Palmgren (:mats) from comment #6) > Comment on attachment 8967987 [details] > Bug 1453702: [css-display] Move unboxing to style, and handle display: > contents before other suppresions. > > https://reviewboard.mozilla.org/r/236674/#review242470 > > r- because this patch breaks the following testcase: > > <details> > <div style="display:contents; color:blue"> > <summary>summary</summary> > details > </div> > </details> Great catch, will amend it :) > ::: commit-message-7aad6:9 > (Diff revision 2) > > +support display: contents until a use case appears. > > + > > +This makes our behavior consistent both with the spec and also in terms of > > +handling dynamic changes to stuff that would otherwise get suppressed. > > + > > +Also makes us consistent with both Blink and WebKit in terms of computed style. > > nit: as far as I know, Blink and WebKit share the same style system and > layout code for the most part. I think "Blink and WebKit" implies that they > should be thought of as separate independent UAs. I disagree; I think they > should be viewed as one CSS implementation (and count as one UA in that > respect), so I think "Blink/WebKit" is a better term here. Well, the display: contents code and style code at least has changed a bit for sure. But sure, can reword that if you want.
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Assignee | ||
Comment 11•6 years ago
|
||
Xidorn, could you review the Rust bits? Thanks!
Comment 12•6 years ago
|
||
mozreview-review |
Comment on attachment 8967987 [details] Bug 1453702: [css-display] Move unboxing to style, and handle display: contents before other suppressions. https://reviewboard.mozilla.org/r/236674/#review242486 I only had a look at the Rust bits and the new wpts, and they look good to me with the following nits addressed: ::: servo/components/style/dom.rs:440 (Diff revision 3) > fn is_html_element(&self) -> bool; > > + /// Return whether this element is an element in the MathML namespace. > + fn is_mathml_element(&self) -> bool; > + > + /// Return whether this element is an element in the MathML namespace. "in the **SVG** namespace". ::: servo/components/style/dom.rs:443 (Diff revision 3) > + fn is_mathml_element(&self) -> bool; > + > + /// Return whether this element is an element in the MathML namespace. > + fn is_svg_element(&self) -> bool; > + > + /// Return whether this element is an element in the MathML namespace. "in the **XUL** namespace". ::: servo/components/style/style_adjuster.rs:456 (Diff revision 3) > + // https://drafts.csswg.org/css-display/#unbox-svg > + lazy_static! { > + static ref SPECIAL_SVG_ELEMENTS: [Atom; 6] = [ > + atom!("svg"), atom!("a"), atom!("g"), atom!("use"), > + atom!("tspan"), atom!("textPath"), > + ]; > + } > + > + let local_name = element.local_name(); > + if !SPECIAL_SVG_ELEMENTS.iter().any(|name| &**name == local_name) { > + self.style.mutate_box().set_display(Display::None); > + } > + return; This doesn't seem to exactly match what the spec says. The spec mentions that "unknown elements" should be handled like these special SVG elements. Maybe add a comment here mentioning that is enough for now.
Attachment #8967987 -
Flags: review?(xidorn+moz) → review+
Comment 13•6 years ago
|
||
mozreview-review |
Comment on attachment 8967987 [details] Bug 1453702: [css-display] Move unboxing to style, and handle display: contents before other suppressions. https://reviewboard.mozilla.org/r/236674/#review242484 r=mats with those issues addressed ::: commit-message-7aad6:9 (Diff revision 3) > +support display: contents until a use case appears. > + > +This makes our behavior consistent both with the spec and also in terms of > +handling dynamic changes to stuff that would otherwise get suppressed. > + > +Also makes us consistent with both Blink and WebKit in terms of computed style. Yes, please :-) I'd prefer "Blink/WebKit" instead of "Blink and WebKit" (two places) ::: layout/base/nsCSSFrameConstructor.cpp:5555 (Diff revision 3) > +// Whether we should suppress frames for a children under a <select> frame. > +// typo: s/a children/a child/ ::: layout/base/nsCSSFrameConstructor.cpp:5561 (Diff revision 3) > +ShouldSuppressFrameInSelect(const nsIContent& aParent, > + const nsIContent& aChild) I'd prefer we use "const nsIContent*" for now, for code style consistency. (Also, it's not clear to me if T& or NotNull<T*> is the preferred style we should adopt if we decide to move away from nsIContent*) ::: layout/base/nsCSSFrameConstructor.cpp:5582 (Diff revision 3) > + if (aChild.IsHTMLElement(nsGkAtoms::optgroup) && > + aChild.IsHTMLElement(nsGkAtoms::select)) { Looks like a copy-paste error. The original code was: (\!aContent->IsHTMLElement(nsGkAtoms::optgroup) || \!parent->IsHTMLElement(nsGkAtoms::select)) && so I think you want to replace the 2nd aChild with aParent. Please add a testcase that would have caught this.
Attachment #8967987 -
Flags: review?(mats) → review+
Comment 14•6 years ago
|
||
mozreview-review |
Comment on attachment 8968087 [details] Bug 1453702: Get rid of SetAsUndisplayedContent. https://reviewboard.mozilla.org/r/236760/#review242488 ::: commit-message-47216:1 (Diff revision 1) > +Bug 1453702: Cleanup SetAsUndisplayedContent. r?mats > + Please amend the commit message with something that explains the change rather than just "cleanup" (which make it sound as if the patch is idempotent, which it isn't for DEBUG builds). I'm guessing the aComputedStyle->GetPseudo() check is redundant since all generated content is presumed to have a pseudo? ::: layout/base/nsCSSFrameConstructor.cpp (Diff revision 1) > - if (aIsGeneratedContent) { > + if (aIsGeneratedContent) { > - aContent->UnbindFromTree(); > + aContent->UnbindFromTree(); > - } > + } > - return; > - } > - MOZ_ASSERT(!aIsGeneratedContent, "Should have had pseudo type"); Hmm, don't we want to keep this assertion somewhere? I'm pretty sure it was added because we have/had code (other than just this place) that depended on this invariant. Is that not true anymore?
Assignee | ||
Comment 15•6 years ago
|
||
(In reply to Mats Palmgren (:mats) from comment #13) > Comment on attachment 8967987 [details] > Bug 1453702: [css-display] Move unboxing to style, and handle display: > contents before other suppressions. > > https://reviewboard.mozilla.org/r/236674/#review242484 > > r=mats with those issues addressed > > ::: commit-message-7aad6:9 > (Diff revision 3) > > +support display: contents until a use case appears. > > + > > +This makes our behavior consistent both with the spec and also in terms of > > +handling dynamic changes to stuff that would otherwise get suppressed. > > + > > +Also makes us consistent with both Blink and WebKit in terms of computed style. > > Yes, please :-) I'd prefer "Blink/WebKit" instead of "Blink and WebKit" (two > places) > > ::: layout/base/nsCSSFrameConstructor.cpp:5555 > (Diff revision 3) > > +// Whether we should suppress frames for a children under a <select> frame. > > +// > > typo: s/a children/a child/ > > ::: layout/base/nsCSSFrameConstructor.cpp:5561 > (Diff revision 3) > > +ShouldSuppressFrameInSelect(const nsIContent& aParent, > > + const nsIContent& aChild) > > I'd prefer we use "const nsIContent*" for now, for code style consistency. > (Also, it's not clear to me if T& or NotNull<T*> is the preferred style > we should adopt if we decide to move away from nsIContent*) Most new DOM and editor code uses Element& / nsIContent& / etc, so I think it's not a big issue to adopt that too. > ::: layout/base/nsCSSFrameConstructor.cpp:5582 > (Diff revision 3) > > + if (aChild.IsHTMLElement(nsGkAtoms::optgroup) && > > + aChild.IsHTMLElement(nsGkAtoms::select)) { > > Looks like a copy-paste error. > The original code was: > (\!aContent->IsHTMLElement(nsGkAtoms::optgroup) || > \!parent->IsHTMLElement(nsGkAtoms::select)) && > so I think you want to replace the 2nd aChild with aParent. > Please add a testcase that would have caught this. This was caught by the innertext getter test.
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment 18•6 years ago
|
||
Pushed by ecoal95@gmail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/43862b2ee72e [css-display] Move unboxing to style, and handle display: contents before other suppressions. r=mats,xidorn
Assignee | ||
Comment 20•6 years ago
|
||
Actually let's just move that to another bug, given I have another idea to remove SetAsUndisplayedContent altogether.
Keywords: leave-open
Assignee | ||
Updated•6 years ago
|
Attachment #8968087 -
Flags: review?(mats)
Assignee | ||
Updated•6 years ago
|
Attachment #8968087 -
Attachment is obsolete: true
Created web-platform-tests PR https://github.com/w3c/web-platform-tests/pull/10489 for changes under testing/web-platform/tests
Comment hidden (mozreview-request) |
Assignee | ||
Updated•6 years ago
|
Attachment #8967987 -
Attachment is obsolete: true
Assignee | ||
Comment 23•6 years ago
|
||
Comment on attachment 8968087 [details] Bug 1453702: Get rid of SetAsUndisplayedContent. Blerg, wrong bug.
Attachment #8968087 -
Flags: review?(mats)
Upstream web-platform-tests status checks passed, PR will merge once commit reaches central.
Comment 25•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/43862b2ee72e
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox61:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
Updated•6 years ago
|
status-firefox59:
--- → unaffected
status-firefox60:
--- → unaffected
status-firefox-esr52:
--- → unaffected
Flags: in-testsuite? → in-testsuite+
Upstream PR merged
Comment 27•6 years ago
|
||
Pushed by ecoal95@gmail.com: https://hg.mozilla.org/integration/autoland/rev/86badb90129d followup: Fix Servo build. r=me
Comment 28•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/86badb90129d
You need to log in
before you can comment on or make changes to this bug.
Description
•