1453704 - Port bug 1453281 to TB: Remove obsolete menubar binding and styling

Status: RESOLVED FIXED

(Thunderbird :: General, enhancement)

Description

[Richard Marti (:Paenglab)]

In bug 1453281 the menubar binding was removed.

Comment 1

[Richard Marti (:Paenglab)]

Attachment: menubar.patch

In https://hg.mozilla.org/mozilla-central/rev/7a26b1da04e5 they added a <toolbar type"menubar"> around <menubar> which was directly below a <toolbox> and removed some styling on correct <menubar> below a existing <toolbar type"menubar">.
I followed tin schema also with not indenting the <menubar> below a new <toolbar type"menubar">.

To be honest, I see no difference with and without this patch. But we are in sync with m-c.

Comment 2

[Jorg K (CEST = GMT+2)]

Comment on attachment 8967412 [details] [diff] [review]
menubar.patch

Review of attachment 8967412 [details] [diff] [review]:
-----------------------------------------------------------------

::: mail/base/content/mainNavigationToolbox.inc
@@ -29,5 @@
>             mode="icons"
>             insertbefore="tabs-toolbar"
>             prependmenuitem="true">
>      <toolbaritem id="menubar-items" align="center">
> -      <menubar id="mail-menubar" style="border:0px;padding:0px;margin:0px;-moz-appearance:none">

This style isn't needed? Also two more further down.
And no <toolbar> needed here since it already sits in a <toolbar><toolbaritem>? I can't see it from the context.

Comment 3

[Richard Marti (:Paenglab)]

(In reply to Jorg K (GMT+1) from comment #2)
> Comment on attachment 8967412 [details] [diff] [review]
> menubar.patch
> 
> Review of attachment 8967412 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: mail/base/content/mainNavigationToolbox.inc
> @@ -29,5 @@
> >             mode="icons"
> >             insertbefore="tabs-toolbar"
> >             prependmenuitem="true">
> >      <toolbaritem id="menubar-items" align="center">
> > -      <menubar id="mail-menubar" style="border:0px;padding:0px;margin:0px;-moz-appearance:none">
> 
> This style isn't needed? Also two more further down.

No, now it's no more needed because now is no style applied that needs to be overridden. Also like https://hg.mozilla.org/mozilla-central/rev/7a26b1da04e5#l1.13

> And no <toolbar> needed here since it already sits in a
> <toolbar><toolbaritem>? I can't see it from the context.

Yes, correct. It's not directly visible because this file is included into messenger.xul and messageWindow.xul, there the <toolbar><toolbaritem> are placed.

Comment 4

[Jorg K (CEST = GMT+2)]

Comment on attachment 8967412 [details] [diff] [review]
menubar.patch

I can't see a difference either. Surely I can't look at Calendar, but I looked at the source view.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/f78d715d7572
Port bug 1453281 to TB: Remove obsolete menubar binding and styling. r=jorgk