1453721 - consider if workers should continue to work through a document.open()

Status: RESOLVED FIXED

(Core :: DOM: Workers, enhancement, P2)

Description

[Ben Kelly [:bkelly, not reviewing]]

While investigating various issues with document.open() re-parenting DETH objects in bug 1451913 I looked into our worker behavior.  Currently we cancel workers from FreeInnerObjects() by calling CancelWorkersForWindow().

I tried remapping things in RuntimeService's mWindowMap and the WorkerLoadInfo's mWindow/ID.  Unfortunately it ran into assertions here:

https://searchfox.org/mozilla-central/rev/4114ad2cfcbc511705c7865a4a34741812f9a2a9/dom/workers/WorkerRunnable.cpp#360

For now I punted on changing workers for document.open().  We can live with just canceling them.  I believe other browsers, like chrome, allow the workers to continue.  They don't replace their windows on document.open().

Comment 1

[Ben Kelly [:bkelly, not reviewing]]

Attachment: worker-document-open-wip.patch

This was my WIP before punting.

Comment 2

[Ben Kelly [:bkelly, not reviewing]]

Attachment: worker_test.patch

To test I modified test_suspend.html to use document.open().

Comment 3

[Boris Zbarsky [:bzbarsky]]

Fixed by bug 1489308, since document.open no longer changes the inner window.