Closed
Bug 1453739
Opened 6 years ago
Closed 6 years ago
Remove Photo on MOSS Landing Page
Categories
(www.mozilla.org :: Bedrock, enhancement)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: lindsey, Unassigned)
Details
(Whiteboard: [good first bug] )
Attachments
(1 file)
We would like to remove the header photo (https://www.mozilla.org/media/img/mozorg/moss/header-home.1053fbeb417f.jpg) on the MOSS program landing page (https://www.mozilla.org/en-US/moss/).
Updated•6 years ago
|
Whiteboard: [good first bug]
Comment 1•6 years ago
|
||
Hi, Could I work on this issue?
Comment 2•6 years ago
|
||
removing the following lines from the source code of "https://www.mozilla.org/en-US/moss/" solves the problem 721: <div id="header-image"> 722: <div id="header-image-wrapper"> 723: <img src="/media/img/mozorg/moss/header-home.1053fbeb417f.jpg" alt=""> 724: </div> 725: </div> also, the styles of #header-image, #header-image-wrapper and #header-image-wrapper>img from "https://www.mozilla.org/media/css/moss-bundle.45de9e94cb77.css" should also be removed. how can i help?
Flags: needinfo?(lindsey)
appreciate the offers of help but does anyone know where this lives and who owns the repo/has access?
Comment 4•6 years ago
|
||
the source code for this page is in https://github.com/mozilla/bedrock/blob/master/bedrock/mozorg/templates/mozorg/moss/index.html to remove the header photo you could just remove the following code : {% block header_image %} <div id="header-image-wrapper"> <img src="{{ static('img/mozorg/moss/header-home.jpg') }}" alt=""> </div> {% endblock %}
Comment 5•6 years ago
|
||
Comment 6•6 years ago
|
||
Hello!! I am pretty much new to open source. Don't know how to start. But I am interested in solving this issue. Can someone guide me, the correct procedure to approach this / get assigned this bug ??
Comment 7•6 years ago
|
||
(In reply to Lindsey from comment #3) > appreciate the offers of help but does anyone know where this lives and who > owns the repo/has access? Lindsey - bedrock / mozilla.org, managed by MozMEAO, is an open source and community friendly project. This bug, a very simple change request, was flagged as a 'good first bug' for someone wanting to get their feet wet and contribute. The pull request has been submitted (see Comment 5) and will be reviewed (this step is required) by a developer with commit privileges to bedrock. When approved (r+), the pull request will be merged to the master and then pushed to go live.
Flags: needinfo?(lindsey)
Comment 8•6 years ago
|
||
I would like to take this bug if it is open. Also, this is my first time so any advice?
(In reply to Eric Renaud [:erenaud] from comment #7) > (In reply to Lindsey from comment #3) > > appreciate the offers of help but does anyone know where this lives and who > > owns the repo/has access? > > Lindsey - bedrock / mozilla.org, managed by MozMEAO, is an open source and > community friendly project. This bug, a very simple change request, was > flagged as a 'good first bug' for someone wanting to get their feet wet and > contribute. > > The pull request has been submitted (see Comment 5) and will be reviewed > (this step is required) by a developer with commit privileges to bedrock. > When approved (r+), the pull request will be merged to the master and then > pushed to go live. Thanks so much for the clarification, Eric! Really appreciated.
Flags: needinfo?(lindsey)
Comment 10•6 years ago
|
||
Commit pushed to master at https://github.com/mozilla/bedrock https://github.com/mozilla/bedrock/commit/a346a129d03b500a4ee6a4bc3a0640d260c19ad7 [Fix Bug 1453739] Remove Photo on MOSS Landing Page (#5667) * remove Photo on MOSS Landing Page
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•