1453761 - Adjust font sizes, spacing, and font weights on about:preferences#home

Status: VERIFIED FIXED

(Firefox :: New Tab Page, enhancement, P1)

Description

[Kate Hudson :k88hudson]

The content section of the about:preferences#home needs some adjustments according to abenson

Comment 1

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/activity-stream/pull/4088

Comment 2

[Kate Hudson :k88hudson]

Attachment: Bug 1453761 - Adjust font sizes, spacing, and font weights on about:preferences#home

Review commit: https://reviewboard.mozilla.org/r/236154/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/236154/

Comment 3

[Ed Lee :Mardak]

Comment on attachment 8967496 [details]
Bug 1453761 - Adjust font sizes, spacing, and font weights on about:preferences#home

https://reviewboard.mozilla.org/r/236154/#review241984

Potentially this patch would just add margin-top to #homepageAndNewWindowsOption and do the contents stuff from activity stream AboutPreferences css?

::: browser/components/preferences/in-content/home.xul:30
(Diff revision 1)
>              data-l10n-id="home-restore-defaults"
>              preference="pref.browser.homepage.disable_button.restore_default"/>
>    </hbox>
>    <description data-l10n-id="home-new-windows-tabs-description2" />
>  
> -  <groupbox>
> +  <vbox class="subGroup">

Does there need to be a matching change for "contents" sub group just above the checkboxes? Although I see that there's the 0.9em for every checkbox being added instead of the 20px. It's intended that these are different?

Alternatively, if this is just for the dropdowns, could just set the margin-top on #homepageAndNewWindowsOption

::: browser/themes/shared/incontentprefs/preferences.inc.css:319
(Diff revision 1)
> +  margin-top: 0.9em;
> +}
> +#homeContentsGroup [data-subcategory] > checkbox {
> +  font-weight: 600;
> +}
> +#homeContentsGroup [data-subcategory] > vbox menulist {

Do we want these closer to the code that generates the content:
https://searchfox.org/mozilla-central/source/browser/extensions/activity-stream/lib/AboutPreferences.jsm#49-56

or I suppose that one rule could just move to this file… The intent to have it in the jsm was that there wouldn't need to be a separate m-c change.

Comment 4

[Kate Hudson :k88hudson]

Comment on attachment 8967496 [details]
Bug 1453761 - Adjust font sizes, spacing, and font weights on about:preferences#home

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/236154/diff/1-2/

Comment 5

[Ed Lee :Mardak]

Comment on attachment 8967496 [details]
Bug 1453761 - Adjust font sizes, spacing, and font weights on about:preferences#home

https://reviewboard.mozilla.org/r/236154/#review242312

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/eb8002dda30c
Adjust font sizes, spacing, and font weights on about:preferences#home r=Mardak

Comment 7

[[github robot]]

Commits pushed to master at https://github.com/mozilla/activity-stream

https://github.com/mozilla/activity-stream/commit/24e4f972e86fe3e05e0fef94fbadd6bc156350e0
Bug 1453761 - Make font size of option descriptions larger (design r=abenson)

https://github.com/mozilla/activity-stream/commit/484c03c13314e750c0896ecfc41e157d9af1cdaa
Merge pull request #4088 from k88hudson/stylefixesprefs

Bug 1453761 - Make font size of option descriptions larger

Comment 8

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/eb8002dda30c

Comment 9

[Ed Lee :Mardak]

https://hg.mozilla.org/mozilla-central/rev/9896401414cb

Comment 10

[Ciprian Muresan [:cmuresan], Ecosystem QA]

The issue is no longer reproducible on the latest Nightly 61.0a1 on Windows 10, Mac 10.12.6 and Arch Linux x64.