Closed
Bug 1453766
Opened 6 years ago
Closed 6 years ago
Update crash ping documentation to mention StartupCrash
Categories
(Toolkit :: Crash Reporting, defect)
Toolkit
Crash Reporting
Tracking
()
RESOLVED
FIXED
mozilla61
Tracking | Status | |
---|---|---|
firefox61 | --- | fixed |
People
(Reporter: akomar, Assigned: gsvelto)
References
Details
Attachments
(1 file)
The crash ping documentation is missing metadata.StartupCrash field.
Comment 1•6 years ago
|
||
Gabriele, is this something you can take a look at?
Component: Telemetry → Crash Reporting
Flags: needinfo?(gsvelto)
Assignee | ||
Comment 2•6 years ago
|
||
Sure, taking this.
Assignee: nobody → gsvelto
Status: NEW → ASSIGNED
Flags: needinfo?(gsvelto)
Comment hidden (mozreview-request) |
Assignee | ||
Comment 4•6 years ago
|
||
I took the liberty of updating a few more fields to clarify what they do.
Comment 5•6 years ago
|
||
mozreview-review |
Comment on attachment 8967759 [details] Bug 1453766 - Improve the documentation of the crash ping's metadata fields; https://reviewboard.mozilla.org/r/236464/#review242234 Thanks!
Attachment #8967759 -
Flags: review?(gfritzsche) → review+
Reporter | ||
Comment 7•6 years ago
|
||
That's great, thanks!
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Flags: needinfo?(akomarzewski)
Resolution: --- → FIXED
Assignee | ||
Comment 8•6 years ago
|
||
We still have to land this :)
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Pushed by gsvelto@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/dc31fa8322c2 Improve the documentation of the crash ping's metadata fields; r=gfritzsche
Comment 10•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/dc31fa8322c2
Status: REOPENED → RESOLVED
Closed: 6 years ago → 6 years ago
status-firefox61:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
Reporter | ||
Comment 11•6 years ago
|
||
Gabriele, I think documented type of `StartupCrash` is not quite right - it's actually String, not an Int.
Flags: needinfo?(gsvelto)
Assignee | ||
Comment 12•6 years ago
|
||
(In reply to akomarzewski from comment #11) > Gabriele, I think documented type of `StartupCrash` is not quite right - > it's actually String, not an Int. You mean in the actual ping? I believe the way it is assembled all the fields under metadata are encoded as strings but boolean fields like StartupCrash will always be set to "1" for true or "0" for false (or absent which usually means false). Since these come from crash annotations I decided to stick with the annotation's type because that's how it should be interpreted.
Flags: needinfo?(gsvelto)
Reporter | ||
Comment 13•6 years ago
|
||
(In reply to Gabriele Svelto [:gsvelto] from comment #12) > You mean in the actual ping? I believe the way it is assembled all the > fields under metadata are encoded as strings but boolean fields like > StartupCrash will always be set to "1" for true or "0" for false (or absent > which usually means false). Since these come from crash annotations I > decided to stick with the annotation's type because that's how it should be > interpreted. I see, looks like it's consistent with other fields after all. Sorry for the false alarm (and thanks again!).
Comment 14•6 years ago
|
||
(In reply to Gabriele Svelto [:gsvelto] from comment #12) > (In reply to akomarzewski from comment #11) > > Gabriele, I think documented type of `StartupCrash` is not quite right - > > it's actually String, not an Int. > > You mean in the actual ping? I believe the way it is assembled all the > fields under metadata are encoded as strings but boolean fields like > StartupCrash will always be set to "1" for true or "0" for false (or absent > which usually means false). Since these come from crash annotations I > decided to stick with the annotation's type because that's how it should be > interpreted. Gabriele, it sounds like we should include in the documentation the casting of all metadata fields to strings. It's a bit surprising on the analysis side.
Flags: needinfo?(gsvelto)
Assignee | ||
Comment 15•6 years ago
|
||
Good point, I'll file another bug for that.
Flags: needinfo?(gsvelto)
You need to log in
before you can comment on or make changes to this bug.
Description
•