1453793 - [traceback] webapp errors out when using TelemetryCrash model

Status: RESOLVED FIXED

(Socorro :: Webapp, task, P1)

Description

[Will Kahn-Greene [:willkg] ET needinfo? me]

In Sentry: https://sentry.prod.mozaws.net/operations/socorro-new-stage/issues/3717322/

"""
TypeError: cannot concatenate 'str' and 'NoneType' objects
  File "django/core/handlers/exception.py", line 41, in inner
    response = get_response(request)
  File "django/core/handlers/base.py", line 187, in _get_response
    response = self.process_exception_by_middleware(e, request)
  File "django/core/handlers/base.py", line 185, in _get_response
    response = wrapped_callback(request, *callback_args, **callback_kwargs)
  File "django/views/decorators/csrf.py", line 58, in wrapped_view
    return view_func(*args, **kwargs)
  File "ratelimit/decorators.py", line 30, in _wrapped
    return fn(*args, **kw)
  File "crashstats/crashstats/utils.py", line 339, in wrapper
    response = f(request, *args, **kw)
  File "crashstats/crashstats/utils.py", line 45, in wrapper
    response = f(request, *args, **kw)
  File "crashstats/api/views.py", line 520, in crash_verify
    telemetry_api.get(crash_id=crash_id, dont_cache=True, refresh_cache=True)
  File "crashstats/crashstats/models.py", line 340, in get
    return self._get(expect_json=expect_json, **kwargs)
  File "crashstats/crashstats/models.py", line 398, in _get
    expect_json=expect_json,
  File "crashstats/crashstats/models.py", line 181, in inner
    result = method(*args, **kwargs)
  File "crashstats/crashstats/models.py", line 271, in fetch
    result = implementation_method(**params)
  File "socorro/external/boto/crash_data.py", line 109, in get
    return self.get_unredacted_processed(params.uuid)
  File "socorro/external/boto/crashstorage.py", line 282, in get_unredacted_processed
    self.config.json_object_hook,
  File "socorro/database/transaction_executor.py", line 105, in __call__
    result = function(connection, *args, **kwargs)
  File "socorro/external/boto/crashstorage.py", line 399, in _do_get_unredacted_processed
    processed_crash_as_string = boto_connection.fetch(crash_id, 'crash_report')
  File "socorro/external/boto/connection_context.py", line 249, in fetch
    bucket = self._get_bucket(conn, self.config.bucket_name)
  File "socorro/external/boto/connection_context.py", line 220, in _get_bucket
    self._bucket_cache[bucket_name] = conn.get_bucket(bucket_name)
  File "boto/s3/connection.py", line 509, in get_bucket
    return self.head_bucket(bucket_name, headers=headers)
  File "boto/s3/connection.py", line 528, in head_bucket
    response = self.make_request('HEAD', bucket_name, headers=headers)
  File "boto/s3/connection.py", line 659, in make_request
    auth_path = self.calling_format.build_auth_path(bucket, key)
  File "boto/s3/connection.py", line 94, in build_auth_path
    path = '/' + bucket
"""

Looks like it happens on both stage and prod. Seems like "bucket" is None. Feels like a configuration error in the webapp.

Comment 1

[Will Kahn-Greene [:willkg] ET needinfo? me]

Making this a P1. This prevents us from using /api/CrashVerify/ to verify crashes got to the appropriate crash storage locations.

Comment 2

[Will Kahn-Greene [:willkg] ET needinfo? me]

For easier testing:

* stage: https://crash-stats.allizom.org/api/CrashVerify/?crash_id=b3a59ed9-fdbb-4f90-b533-6d7990180419
* prod: https://crash-stats.mozilla.com/api/CrashVerify/?crash_id=50d211f1-e049-4a03-aee3-0094f0180419

Comment 3

[Will Kahn-Greene [:willkg] ET needinfo? me]

It's a missing configuration.

PR: https://github.com/mozilla-services/cloudops-deployment/pull/1868

Comment 4

[Will Kahn-Greene [:willkg] ET needinfo? me]

PR 1868 landed in https://github.com/mozilla-services/cloudops-deployment/commit/7050f7e8dd2a69b5cb714dd3359d282521b2c58f

The stage url is still failing. Maybe we haven't done a stage deploy since Miles merged it. I'll follow it up tomorrow.

Comment 5

[Will Kahn-Greene [:willkg] ET needinfo? me]

Yay--stage deployed and it works fine. Marking this as FIXED.