Closed Bug 1453800 Opened 5 years ago Closed 5 years ago

Move the container removal dialog strings to preferences.ftl

Categories

(Firefox :: Settings UI, enhancement, P3)

Product:
Firefox
Component:
Settings UI
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 61
Tracking Flags:
Tracking Status
firefox61 --- fixed

People

(Reporter: zbraniecki, Assigned: zbraniecki)

References

Details

Attachments

(1 file)

Bug 1453800 - Move the container removal dialog strings to preferences.ftl.
59 bytes, text/x-review-board-request
flod
: review+
Details 
Due to my mistake we ended up putting the container removal dialog strings in containers.ftl which is intended for containers subdialog, but the strings are actually needed in main preferences.xul window.

In bug 1453486 we fixed the behavior, by including containers.ftl into preferences.xul. It's not terrible, but suboptimal.

A nicer solution would be to move those 4 strings from containers.ftl to preferences.ftl.

Flod's idea is to write a migration that uses DTD/properties to add 4 new strings to preferences.ftl:

 * "containers-remove-alert-title",
 * "containers-remove-alert-msg",
 * "containers-remove-ok-button",
 * "containers-remove-cancel-button",

based on the same migration code we used in bug 1419547.
Assignee: nobody → gandalf
Status: NEW → ASSIGNED
Priority: -- → P3
See Also: → 1453557
Depends on: 1453486
Locales that only translated the new FTL strings (and will lose their work unless manually moved): gl

Differences fixed in Pontoon (typically an unnecessary leading space in 2nd form): be, bn-BD, ne-NP, te.
Fixed in Mercurial: da.

Arabic doesn't have a [zero] form in FTL.
Comment on attachment 8967534 [details]
Bug 1453800 - Move the container removal dialog strings to preferences.ftl.

https://reviewboard.mozilla.org/r/236214/#review242416

One nit that I didn't notice in bug 1419547.

At this point, it would be great to land this before Monday, hoping to be able to run the two pending migrations together.

::: browser/locales/en-US/browser/preferences/preferences.ftl:185
(Diff revision 2)
> +# Variables:
> +#   $count (Number) - Number of tabs that will be closed.
> +containers-remove-alert-msg =
> +    { $count ->
> +       *[one] If you remove this Container now, { $count } container tab will be closed. Are you sure you want to remove this Container?
> +        [other] If you remove this Container now, { $count } container tabs will be closed. Are you sure you want to remove this Container?

The default should be [other], not [one]
Attachment #8967534 - Flags: review?(francesco.lodolo) → review+
Pushed by zbraniecki@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/ffcb6aa7e871
Move the container removal dialog strings to preferences.ftl. r=flod
https://hg.mozilla.org/mozilla-central/rev/ffcb6aa7e871
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox61: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 61
You need to log in before you can comment on or make changes to this bug.