Closed
Bug 1453809
Opened 6 years ago
Closed 6 years ago
Use ToUint16 in ToUint16Slow
Categories
(Core :: JavaScript Engine, enhancement)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla61
Tracking | Status | |
---|---|---|
firefox61 | --- | fixed |
People
(Reporter: anba, Assigned: anba)
Details
Attachments
(1 file)
2.09 KB,
patch
|
Waldo
:
review+
|
Details | Diff | Splinter Review |
Looks like ToUint16Slow was never really updated to use the more modern detail::ToIntWidth() functions from js/public/Conversions.h: https://searchfox.org/mozilla-central/rev/3b56a9af51519d2e77e05efa672a13e6be2e9ebc/js/src/jsnum.c#470-497
Assignee | ||
Comment 1•6 years ago
|
||
I've also changed js::ToUint8Slow to call JS::ToUint8 for consistency with the other js::To{Ui,I}nt{8,16,32,64}Slow functions.
Attachment #8967564 -
Flags: review?(jwalden+bmo)
Updated•6 years ago
|
Attachment #8967564 -
Flags: review?(jwalden+bmo) → review+
Assignee | ||
Comment 2•6 years ago
|
||
Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=e5ced494b999957fcf4a35e7c7e605683de542bd
Keywords: checkin-needed
Pushed by dluca@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/06911984ea87 Call ToUint16 in ToUint16Slow. r=Waldo
Keywords: checkin-needed
Comment 4•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/06911984ea87
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
You need to log in
before you can comment on or make changes to this bug.
Description
•