Closed Bug 1453809 Opened 6 years ago Closed 6 years ago

Use ToUint16 in ToUint16Slow

Categories

(Core :: JavaScript Engine, enhancement)

enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla61
Tracking Status
firefox61 --- fixed

People

(Reporter: anba, Assigned: anba)

Details

Attachments

(1 file)

Looks like ToUint16Slow was never really updated to use the more modern detail::ToIntWidth() functions from js/public/Conversions.h:

https://searchfox.org/mozilla-central/rev/3b56a9af51519d2e77e05efa672a13e6be2e9ebc/js/src/jsnum.c#470-497
Attached patch bug1453809.patchSplinter Review
I've also changed js::ToUint8Slow to call JS::ToUint8 for consistency with the other js::To{Ui,I}nt{8,16,32,64}Slow functions.
Attachment #8967564 - Flags: review?(jwalden+bmo)
Attachment #8967564 - Flags: review?(jwalden+bmo) → review+
Pushed by dluca@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/06911984ea87
Call ToUint16 in ToUint16Slow. r=Waldo
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/06911984ea87
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
You need to log in before you can comment on or make changes to this bug.