Closed Bug 1453825 Opened 3 years ago Closed 3 years ago

TRR: add telemetry counter for failed/successful NS checks

Categories

(Core :: Networking: DNS, enhancement, P1)

enhancement

Tracking

()

RESOLVED FIXED
mozilla61
Tracking Status
firefox61 --- fixed

People

(Reporter: bagder, Assigned: bagder)

Details

(Whiteboard: [necko-triaged][trr])

Attachments

(1 file)

No description provided.
Comment on attachment 8967581 [details]
bug 1453825 - add telemetry for TRR NS confirmation checks

https://reviewboard.mozilla.org/r/236268/#review242058

1] how does this exclude mode 3 like we discused?

2] does this count all NS lookups (including blacklist verifications?) instead of just resolver health checks?
Attachment #8967581 - Flags: review?(mcmanus)
Right, it was not done correctly. I had blanked out on the fact that it was used for both purposes (while this should only count the actual initial NS verification failures). I've cleaned it up and here follows an even simpler approach...
Comment on attachment 8967581 [details]
bug 1453825 - add telemetry for TRR NS confirmation checks

https://reviewboard.mozilla.org/r/236268/#review242200

it looks like this will count mode 3 successes (but not fails - we want to exclude all mode 3 from the data otherwise its skewed)
Attachment #8967581 - Flags: review?(mcmanus) → review-
Comment on attachment 8967581 [details]
bug 1453825 - add telemetry for TRR NS confirmation checks

https://reviewboard.mozilla.org/r/236268/#review242600
Attachment #8967581 - Flags: review?(mcmanus) → review+
Pushed by daniel@haxx.se:
https://hg.mozilla.org/integration/autoland/rev/00d978a04775
add telemetry for TRR NS confirmation checks r=mcmanus
https://hg.mozilla.org/mozilla-central/rev/00d978a04775
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
Hey Dan,
I wanted to remind you that every new data collection must go through a data collection review.
This also applies to technical or interaction data. See https://wiki.mozilla.org/Firefox/Data_Collection for more.
Flags: needinfo?(daniel)
I consider this as just be a small tweak of the data collection we already got r+'ed before in bug 1436338.

Francois, do we need additional review(s) for this added entry?
Flags: needinfo?(daniel) → needinfo?(francois)
(In reply to Daniel Stenberg [:bagder] from comment #11)
> I consider this as just be a small tweak of the data collection we already
> got r+'ed before in bug 1436338.
> 
> Francois, do we need additional review(s) for this added entry?

Yes, if the answers are the same as https://bugzilla.mozilla.org/show_bug.cgi?id=1436338#c0, you can simply link to that and request a review for the new probe.

Assuming that's true, datareview+.
Flags: needinfo?(francois)
You need to log in before you can comment on or make changes to this bug.