Closed
Bug 1453846
Opened 6 years ago
Closed 6 years ago
Remove RDP packet observation events
Categories
(DevTools :: General, enhancement, P3)
DevTools
General
Tracking
(firefox61 fixed)
RESOLVED
FIXED
Firefox 61
Tracking | Status | |
---|---|---|
firefox61 | --- | fixed |
People
(Reporter: jryans, Assigned: jryans)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
In bug 1126274, we added various `send`, `onPacket` etc. events to allow observing and logging RDP as they flow over the wire. To my knowledge, this was only ever used by the RDP Inspector add-on. This is a legacy add-on, so it no longer works in the WebExtension world. We should remove these event since there is no longer a consumer for them.
Assignee | ||
Comment 1•6 years ago
|
||
Honza, do you agree it's okay to remove these events? RDP Inspector was quite cool, but I am guessing we don't plan to make it work as WebExtension any time soon...
Flags: needinfo?(odvarko)
Comment 2•6 years ago
|
||
(In reply to J. Ryan Stinnett [:jryans] (use ni?) from comment #1) > Honza, do you agree it's okay to remove these events? RDP Inspector was > quite cool, but I am guessing we don't plan to make it work as WebExtension > any time soon... I'd really like to have RDPi refactored on top of WebExtension API/WebExtensions Experiments, but I agree this won't probably happen any time soon. So, yes agree, we can re-add them as soon as needed. Honza
Flags: needinfo?(odvarko)
Comment hidden (mozreview-request) |
Assignee | ||
Comment 4•6 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=4372601d78e452917f627cfd9754362f03a4dd20
Comment hidden (mozreview-request) |
Assignee | ||
Comment 6•6 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=b938fe22797cbd09155e38fe50af1a18cd22add8
Assignee | ||
Updated•6 years ago
|
Assignee: nobody → jryans
Status: NEW → ASSIGNED
Comment 7•6 years ago
|
||
mozreview-review |
Comment on attachment 8967810 [details] Bug 1453846 - Remove DevTools RDP events. https://reviewboard.mozilla.org/r/236486/#review242546 Looks reasonable to me, thanks Ryan! R+ assuming try is green Honza
Attachment #8967810 -
Flags: review?(odvarko) → review+
Comment 8•6 years ago
|
||
We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again. hg error in cmd: hg rebase -s 3c53746e33632fd470d0bc370d4feb3dad97832e -d 99c2396a4c87: rebasing 458581:3c53746e3363 "Bug 1453846 - Remove DevTools RDP events. r=Honza" (tip) merging devtools/client/framework/test/browser.ini merging devtools/shared/transport/transport.js warning: conflicts while merging devtools/shared/transport/transport.js! (edit, then use 'hg resolve --mark') unresolved conflicts (see hg resolve, then hg rebase --continue)
Comment hidden (mozreview-request) |
Comment 10•6 years ago
|
||
Pushed by jryans@gmail.com: https://hg.mozilla.org/integration/autoland/rev/4012129c0b40 Remove DevTools RDP events. r=Honza
Comment 11•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/4012129c0b40
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox61:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 61
Comment 12•6 years ago
|
||
This improved DAMP results on netmonitor, styleeditor and webconsole: https://treeherder.mozilla.org/perf.html#/comparesubtest?originalProject=try&originalRevision=5560db0505a75ebd272867ca6baaf9df19faf131&newProject=try&newRevision=5d01932f26083cff8e42bf5c80a741e42284f7ed&originalSignature=f79b6a4f1f8f53326d3056f6c8008c0ff4de0a94&newSignature=f79b6a4f1f8f53326d3056f6c8008c0ff4de0a94&showOnlyConfident=1&framework=1 -2% on complicated.netmonitor.reload -1.8% on complicated.netmonitor.requestsFinished -1.4% on complicated.styleeditor.open -1.3% on complicated.styleeditor.reload -0.6% on custom.webconsole.reload
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•