Closed Bug 1453846 Opened 2 years ago Closed 2 years ago
Remove RDP packet observation events
In bug 1126274, we added various `send`, `onPacket` etc. events to allow observing and logging RDP as they flow over the wire. To my knowledge, this was only ever used by the RDP Inspector add-on. This is a legacy add-on, so it no longer works in the WebExtension world. We should remove these event since there is no longer a consumer for them.
Honza, do you agree it's okay to remove these events? RDP Inspector was quite cool, but I am guessing we don't plan to make it work as WebExtension any time soon...
(In reply to J. Ryan Stinnett [:jryans] (use ni?) from comment #1) > Honza, do you agree it's okay to remove these events? RDP Inspector was > quite cool, but I am guessing we don't plan to make it work as WebExtension > any time soon... I'd really like to have RDPi refactored on top of WebExtension API/WebExtensions Experiments, but I agree this won't probably happen any time soon. So, yes agree, we can re-add them as soon as needed. Honza
2 years ago
Assignee: nobody → jryans
Status: NEW → ASSIGNED
Comment on attachment 8967810 [details] Bug 1453846 - Remove DevTools RDP events. https://reviewboard.mozilla.org/r/236486/#review242546 Looks reasonable to me, thanks Ryan! R+ assuming try is green Honza
Attachment #8967810 - Flags: review?(odvarko) → review+
We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again. hg error in cmd: hg rebase -s 3c53746e33632fd470d0bc370d4feb3dad97832e -d 99c2396a4c87: rebasing 458581:3c53746e3363 "Bug 1453846 - Remove DevTools RDP events. r=Honza" (tip) merging devtools/client/framework/test/browser.ini merging devtools/shared/transport/transport.js warning: conflicts while merging devtools/shared/transport/transport.js! (edit, then use 'hg resolve --mark') unresolved conflicts (see hg resolve, then hg rebase --continue)
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/autoland/rev/4012129c0b40 Remove DevTools RDP events. r=Honza
This improved DAMP results on netmonitor, styleeditor and webconsole: https://treeherder.mozilla.org/perf.html#/comparesubtest?originalProject=try&originalRevision=5560db0505a75ebd272867ca6baaf9df19faf131&newProject=try&newRevision=5d01932f26083cff8e42bf5c80a741e42284f7ed&originalSignature=f79b6a4f1f8f53326d3056f6c8008c0ff4de0a94&newSignature=f79b6a4f1f8f53326d3056f6c8008c0ff4de0a94&showOnlyConfident=1&framework=1 -2% on complicated.netmonitor.reload -1.8% on complicated.netmonitor.requestsFinished -1.4% on complicated.styleeditor.open -1.3% on complicated.styleeditor.reload -0.6% on custom.webconsole.reload
You need to log in before you can comment on or make changes to this bug.