Closed Bug 1453894 Opened 4 years ago Closed 4 years ago

Closing console sidebar with Escape key does not give focus back to the console input

Categories

(DevTools :: Console, defect, P3)

defect

Tracking

(firefox61 fixed)

RESOLVED FIXED
Firefox 61
Tracking Status
firefox61 --- fixed

People

(Reporter: nchevobbe, Assigned: nchevobbe)

Details

Attachments

(1 file)

**Steps to reproduce**
1. Navigate to `data:text/html,<meta charset=utf8><script>console.log({a: 1})</script>`
2. Open the webconsole
3. Right-click on `Object { a: 1}`, and select `Open in sidebar`
4. Hit the Escape key

**Expected results**

The sidebar closes and the console input gets focused

**Actual results**

The sidebar do close, but the focus isn't restored to the console input

---
Has STR: --- → yes
Priority: -- → P3
Assignee: nobody → nchevobbe
Status: NEW → ASSIGNED
Comment on attachment 8968128 [details]
Bug 1453894 - Give focus to console input when closing sidebar with Escape key; .

https://reviewboard.mozilla.org/r/236804/#review242548

Works for me, thanks Nicolas!
R+ assuming try is green
Honza
Attachment #8968128 - Flags: review?(odvarko) → review+
Pushed by nchevobbe@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/212963ca6f2b
Give focus to console input when closing sidebar with Escape key; r=Honza.
https://hg.mozilla.org/mozilla-central/rev/212963ca6f2b
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 61
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.