1453898 - Intermittent browser/components/preferences/in-content/tests/browser_fluent.js | {"value":null,"attrs":[{"name":"label","value":"4 (default)"}]} deepEqual {"value":null,"attrs":[{"name":"label","value":"4"}]} - JS frame

Status: RESOLVED FIXED

(Firefox :: Settings UI, defect, P5)

Description

[Treeherder Bug Filer]

Filed by: ccoroiu [at] mozilla.com

https://treeherder.mozilla.org/logviewer.html#?job_id=173437706&repo=autoland

https://queue.taskcluster.net/v1/task/WyqSLFWzTfqVLW-8pZvMBw/runs/0/artifacts/public/logs/live_backing.log

[task 2018-04-13T06:29:07.075Z] 06:29:07     INFO - TEST-START | browser/components/preferences/in-content/tests/browser_fluent.js
[task 2018-04-13T06:29:07.205Z] 06:29:07     INFO - GECKO(7987) | ERROR 2018-04-13T06:29:07Z: webrender::display_list_flattener: Unknown pipeline used for iframe IframeDisplayItem { clip_id: Clip(4, PipelineId(1, 1)), pipeline_id: PipelineId(1, 10) }
[task 2018-04-13T06:29:07.229Z] 06:29:07     INFO - GECKO(7987) | ERROR 2018-04-13T06:29:07Z: webrender::display_list_flattener: Unknown pipeline used for iframe IframeDisplayItem { clip_id: Clip(4, PipelineId(1, 1)), pipeline_id: PipelineId(1, 10) }
[task 2018-04-13T06:29:08.061Z] 06:29:08     INFO - TEST-INFO | started process screentopng
[task 2018-04-13T06:29:08.899Z] 06:29:08     INFO - TEST-INFO | screentopng: exit 0
[task 2018-04-13T06:29:08.901Z] 06:29:08     INFO - Buffered messages logged at 06:29:07
[task 2018-04-13T06:29:08.902Z] 06:29:08     INFO - Entering test bound 
[task 2018-04-13T06:29:08.904Z] 06:29:08     INFO - Buffered messages finished
[task 2018-04-13T06:29:08.905Z] 06:29:08     INFO - TEST-UNEXPECTED-FAIL | browser/components/preferences/in-content/tests/browser_fluent.js | {"value":null,"attrs":[{"name":"label","value":"4 (default)"}]} deepEqual {"value":null,"attrs":[{"name":"label","value":"4"}]} - JS frame :: chrome://mochitests/content/browser/browser/components/preferences/in-content/tests/browser_fluent.js :: <TOP_LEVEL> :: line 40
[task 2018-04-13T06:29:08.905Z] 06:29:08     INFO - Stack trace:
[task 2018-04-13T06:29:08.906Z] 06:29:08     INFO - chrome://mochitests/content/browser/browser/components/preferences/in-content/tests/browser_fluent.js:null:40
[task 2018-04-13T06:29:08.906Z] 06:29:08     INFO - Leaving test bound 
[task 2018-04-13T06:29:08.907Z] 06:29:08     INFO - GECKO(7987) | MEMORY STAT | vsize 2500MB | residentFast 579MB | heapAllocated 348MB
[task 2018-04-13T06:29:08.908Z] 06:29:08     INFO - TEST-OK | browser/components/preferences/in-content/tests/browser_fluent.js | took 1095ms
[task 2018-04-13T06:29:08.909Z] 06:29:08     INFO - checking window state
[task 2018-04-13T06:29:09.170Z] 06:29:09     INFO - GECKO(7987) | ERROR 2018-04-13T06:29:09Z: webrender::display_list_flattener: Unknown pipeline used for iframe IframeDisplayItem { clip_id: Clip(4, PipelineId(1, 1)), pipeline_id: PipelineId(1, 11) }
[task 2018-04-13T06:29:09.885Z] 06:29:09     INFO - GECKO(7987) | ERROR 2018-04-13T06:29:09Z: webrender::display_list_flattener: Unknown pipeline used for iframe IframeDisplayItem { clip_id: Clip(4, PipelineId(1, 1)), pipeline_id: PipelineId(1, 11) }
[task 2018-04-13T06:29:10.346Z] 06:29:10     INFO - GECKO(7987) | Completed ShutdownLeaks collections in process 8157
[task 2018-04-13T06:29:10.392Z] 06:29:10     INFO - GECKO(7987) | Completed ShutdownLeaks collections in process 8103
[task 2018-04-13T06:29:10.410Z] 06:29:10     INFO - GECKO(7987) | Completed ShutdownLeaks collections in process 8127
[task 2018-04-13T06:29:10.427Z] 06:29:10     INFO - GECKO(7987) | Completed ShutdownLeaks collections in process 8048
[task 2018-04-13T06:29:10.905Z] 06:29:10     INFO - GECKO(7987) | Completed ShutdownLeaks collections in process 7987

Comment 1

[Zibi Braniecki [:zbraniecki][:gandalf]]

we may want to remove this test. It was originally serving us to verify that fluent works when we migrated the first string, but now with whole Prefs in Fluent we probably don't need it, and it tests the variable for default process count which may change?

Comment 2

[Intermittent Failures Robot]

4 failures in 792 pushes (0.005 failures/push) were associated with this bug in the last 7 days.    

Repository breakdown:
* autoland: 3
* mozilla-inbound: 1

Platform breakdown:
* linux64-qr: 4

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1453898&startday=2018-04-09&endday=2018-04-15&tree=trunk

Comment 3

[Ryan VanderMeulen [:RyanVM]]

This is hella-frequent. Removing sounds good.

Comment 4

[Ryan VanderMeulen [:RyanVM]]

Nevermind, the one I'm seeing on 60 was from a broken uplift.

Comment 5

[Intermittent Failures Robot]

22 failures in 117 pushes (0.188 failures/push) were associated with this bug yesterday.    

Repository breakdown:
* mozilla-beta: 22

Platform breakdown:
* linux64: 4
* osx-10-10: 2
* macosx64-nightly: 2
* macosx64-devedition: 2
* linux64-devedition: 2
* linux32-nightly: 2
* linux32-devedition: 2
* windows7-32: 1
* windows10-64: 1
* linux64-stylo-disabled: 1
* linux64-nightly: 1
* linux32-stylo-disabled: 1
* linux32: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1453898&startday=2018-04-16&endday=2018-04-16&tree=trunk

Comment 6

[Zibi Braniecki [:zbraniecki][:gandalf]]

Attachment: Bug 1453898 - Change the l10n id used in browser_fluent mochitest.

Review commit: https://reviewboard.mozilla.org/r/237308/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/237308/

Comment 7

[Zibi Braniecki [:zbraniecki][:gandalf]]

I can't reproduce the intermittent, but my guess is that because this l10n-id is set from JS it's prone to racing. Before we remove the test, I'd like to give a try switching it to test against regular DOM l10n-id. I used this ID because it exposes:
 - attributes
 - message references
 - and is upstreamable to beta

Comment 8

[Zibi Braniecki [:zbraniecki][:gandalf]]

Comment on attachment 8968611 [details]
Bug 1453898 - Change the l10n id used in browser_fluent mochitest.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/237308/diff/1-2/

Comment 9

[Code Review Bot [:reviewbot]]

Comment on attachment 8968611 [details]
Bug 1453898 - Change the l10n id used in browser_fluent mochitest.

https://reviewboard.mozilla.org/r/237308/#review243110


Code analysis found 1 defect in this patch:
 - 1 defect found by mozlint

You can run this analysis locally with:
 - `./mach lint path/to/file` (JS/Python)


If you see a problem in this automated review, please report it here: http://bit.ly/2y9N9Vx


::: browser/components/preferences/in-content/tests/browser_fluent.js:31
(Diff revision 1)
>    let doc = gBrowser.contentDocument;
>    let win = gBrowser.contentWindow;
>    await doc.l10n.ready;
>  
>    let processCountPref = win.Preferences.get("dom.ipc.processCount");
>    let defaultProcessCount = processCountPref.defaultValue;

Error: 'defaultprocesscount' is assigned a value but never used. [eslint: no-unused-vars]

Comment 10

[Zibi Braniecki [:zbraniecki][:gandalf]]

gotcha Code Review Bot. I managed to push the linter fix before you complained! Joke's on you!

Comment 11

[Axel Hecht [:Pike]]

Comment on attachment 8968611 [details]
Bug 1453898 - Change the l10n id used in browser_fluent mochitest.

https://reviewboard.mozilla.org/r/237308/#review243702

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9130155caf45
Change the l10n id used in browser_fluent mochitest. r=Pike

Comment 13

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/9130155caf45

Comment 14

[Intermittent Failures Robot]

21 failures in 782 pushes (0.027 failures/push) were associated with this bug in the last 7 days.    

Repository breakdown:
* mozilla-beta: 21

Platform breakdown:
* linux64: 5
* windows10-64: 2
* osx-10-10: 2
* macosx64-nightly: 2
* linux32-devedition: 2
* windows7-32: 1
* macosx64-devedition: 1
* linux64-stylo-disabled: 1
* linux64-nightly: 1
* linux64-devedition: 1
* linux32-stylo-disabled: 1
* linux32-nightly: 1
* linux32: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1453898&startday=2018-04-16&endday=2018-04-22&tree=trunk