Closed Bug 1453921 Opened 6 years ago Closed 6 years ago

Allow to inline String.fromCharCode for more input types

Categories

(Core :: JavaScript Engine: JIT, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
mozilla61
Tracking Status
firefox61 --- fixed

People

(Reporter: anba, Assigned: anba)

Details

Attachments

(1 file)

Also while working on bug 1453809, I've seen that IonBuilder::inlineStrFromCharCode() could be changed to allow to inline String.fromCharCode for more types, similar to the more relaxed conditions for ToInt32 conversions in the various IonBuilder::inlineAtomicsXYZ methods.
Attached patch bug1453921.patchSplinter Review
This relaxes the inlining conditions for String.fromCharCode similar to <https://searchfox.org/mozilla-central/rev/9f3da81290054c5b8955bb67ff98cae66676f745/js/src/jit/MCallOptimize.cpp#3316-3320>.
Attachment #8967683 - Flags: review?(jdemooij)
Comment on attachment 8967683 [details] [diff] [review]
bug1453921.patch

Review of attachment 8967683 [details] [diff] [review]:
-----------------------------------------------------------------

Good find.
Attachment #8967683 - Flags: review?(jdemooij) → review+
Pushed by apavel@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/36688a93952f
Use MTruncateToInt32 when inlining String.fromCharCode. r=jandem
Keywords: checkin-needed
Priority: -- → P3
https://hg.mozilla.org/mozilla-central/rev/36688a93952f
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
You need to log in before you can comment on or make changes to this bug.