Closed
Bug 1453921
Opened 6 years ago
Closed 6 years ago
Allow to inline String.fromCharCode for more input types
Categories
(Core :: JavaScript Engine: JIT, enhancement, P3)
Core
JavaScript Engine: JIT
Tracking
()
RESOLVED
FIXED
mozilla61
Tracking | Status | |
---|---|---|
firefox61 | --- | fixed |
People
(Reporter: anba, Assigned: anba)
Details
Attachments
(1 file)
1.75 KB,
patch
|
jandem
:
review+
|
Details | Diff | Splinter Review |
Also while working on bug 1453809, I've seen that IonBuilder::inlineStrFromCharCode() could be changed to allow to inline String.fromCharCode for more types, similar to the more relaxed conditions for ToInt32 conversions in the various IonBuilder::inlineAtomicsXYZ methods.
Assignee | ||
Comment 1•6 years ago
|
||
This relaxes the inlining conditions for String.fromCharCode similar to <https://searchfox.org/mozilla-central/rev/9f3da81290054c5b8955bb67ff98cae66676f745/js/src/jit/MCallOptimize.cpp#3316-3320>.
Attachment #8967683 -
Flags: review?(jdemooij)
Comment 2•6 years ago
|
||
Comment on attachment 8967683 [details] [diff] [review] bug1453921.patch Review of attachment 8967683 [details] [diff] [review]: ----------------------------------------------------------------- Good find.
Attachment #8967683 -
Flags: review?(jdemooij) → review+
Assignee | ||
Comment 3•6 years ago
|
||
Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=e5ced494b999957fcf4a35e7c7e605683de542bd
Keywords: checkin-needed
Pushed by apavel@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/36688a93952f Use MTruncateToInt32 when inlining String.fromCharCode. r=jandem
Keywords: checkin-needed
Updated•6 years ago
|
Priority: -- → P3
Comment 5•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/36688a93952f
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
You need to log in
before you can comment on or make changes to this bug.
Description
•