Enable handle verifier on 32-bit EARLY_BETA_OR_EARLIER

RESOLVED FIXED in Firefox 61

Status

()

enhancement
P1
normal
RESOLVED FIXED
a year ago
a year ago

People

(Reporter: bobowen, Assigned: bobowen)

Tracking

61 Branch
mozilla61
x86
Windows
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox61 fixed)

Details

Attachments

(1 attachment)

Assignee

Description

a year ago
Bug 1452090 landed changes to enabled hooks on CloseHandle and DuplicateHandle to try and catch where we have Windows handle management issues.
We're fairly sure we have these because they cause crashes in various places.
This uses the handle verifier in the chromium sandbox code, so it means that all handle closes are checked against ones used and tracked by the sandbox.

Also, we now disable the handle verifier in anything other than Nightly and Debug 32-bit builds.

We don't have good coverage for 32-bit on Nightly, so it would be good if we could enable this for EARLY_BETA_OR_EARLIER instead of NIGHTLY_BUILD (I assume that EARLY_BETA_OR_EARLIER includes NIGHTLY_BUILD).

That way we stand a much better chance of catching these handle issues, but we'll still run late Beta with the verifier disabled as for release.

RyanVM - are you the right person to authorise the use of EARLY_BETA_OR_EARLIER?
We could just do it for 61, but it would be good to leave it on as it could catch future problems.
Flags: needinfo?(ryanvm)
I don't think EARLY_BETA_OR_EARLIER needs any sort of authorization to use beyond passing code review since by definition it means code we'll never ship to release users (and we do have safeguards in place to ensure it's the case even if we somehow forgot to unset it mid-cycle). The only caveat is to make sure that the code builds and passes tests either way so you don't end up getting an "XYZ is going to permafail" bug filed on you later :).
Flags: needinfo?(ryanvm)
Attachment #8967792 - Flags: review?(jmathies) → review+

Comment 3

a year ago
Pushed by bobowencode@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/821b3597208e
Enable handle verifier on 32-bit EARLY_BETA_OR_EARLIER. r=jimm

Comment 4

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/821b3597208e
Status: ASSIGNED → RESOLVED
Last Resolved: a year ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
You need to log in before you can comment on or make changes to this bug.