Closed Bug 1453930 Opened 2 years ago Closed 2 years ago

Don't mix GTK_STATE_FLAG_NORMAL/gtk_style_context_get_state(style) to get border/padding/margin

Categories

(Core :: Widget: Gtk, enhancement)

enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla61
Tracking Status
firefox61 --- fixed

People

(Reporter: stransky, Assigned: stransky)

Details

Attachments

(1 file)

Mixing GTK_STATE_FLAG_NORMAL/gtk_style_context_get_state(style) causes theme bugs like Bug 1451792. When using GTK_STATE_FLAG_NORMAL we're missing direction flags for widget borders.
Comment on attachment 8967692 [details]
Bug 1453930 - Use gtk_style_context_get_state() instead of GTK_STATE_FLAG_NORMAL to get widget border/margin/padding,

https://reviewboard.mozilla.org/r/236416/#review242196
Attachment #8967692 - Flags: review?(jhorak) → review+
Pushed by stransky@redhat.com:
https://hg.mozilla.org/integration/autoland/rev/33f57e147c46
Use gtk_style_context_get_state() instead of GTK_STATE_FLAG_NORMAL to get widget border/margin/padding, r=jhorak
https://hg.mozilla.org/mozilla-central/rev/33f57e147c46
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
You need to log in before you can comment on or make changes to this bug.