Closed Bug 1453957 Opened 6 years ago Closed 6 years ago

Stop setting the "unread" attribute on tabs

Categories

(Firefox :: Tabbed Browser, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
Firefox 61
Tracking Status
firefox61 --- fixed

People

(Reporter: dao, Assigned: viditvineet, Mentored)

References

Details

(Keywords: good-first-bug, Whiteboard: [lang=js])

Attachments

(2 files)

+++ This bug was initially created as a clone of Bug #1421785 +++

As per bug 1421785, the unread attribute is unused and we should stop setting it:

https://dxr.mozilla.org/mozilla-central/search?q=regexp%3A%22(set%7Cremove)Attribute%5C(%5C%22unread%5C%22%22&redirect=false
Summary: Add unread to tabs.Tab → Stop setting Tab.unread property
Oops, accidentally cloned bug 1421785's summary.
Summary: Stop setting Tab.unread property → Stop setting the "unread" attrubite on tabs
Summary: Stop setting the "unread" attrubite on tabs → Stop setting the "unread" attribute on tabs
Vivaldi browser has a "Unread Indicator" feature for tabs, maybe Firefox can have this too?
Flags: needinfo?(dao+bmo)
Attached image unread2.PNG
Vivaldi's "Unread Indicator"
Hi, I see that noone is working is working on this bug, could I take this up?
(In reply to kernp25 from comment #2)
> Vivaldi browser has a "Unread Indicator" feature for tabs, maybe Firefox can
> have this too?

This discussion should happen somewhere else such as the firefox-dev mailing list. In the meantime let's stop setting this attribute. We can re-introduce it if and when we decide that we want to use it.

(In reply to Vidit23 from comment #4)
> Hi, I see that noone is working is working on this bug, could I take this up?

Sure!
Assignee: nobody → viditvineet
Flags: needinfo?(dao+bmo)
Hi, sorry for delaying it; I ran into some issue with xpcom while building. Does this look okay?
Comment on attachment 8971678 [details] [diff] [review]
Stop setting the unread attribute on tabs

Looks good. Next time please set the review flag, otherwise it could happen that nobody looks at your patch:

https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/How_to_Submit_a_Patch#Getting_the_patch_reviewed

Thanks!
Attachment #8971678 - Flags: review+
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/92a50917efbc
Stop setting the "unread" attribute on tabs. r=dao
https://hg.mozilla.org/mozilla-central/rev/92a50917efbc
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 61
It is really disappointing to see this removed. I have long had a userChrome style leveraging this attribute:

#tabbrowser-tabs tab[unread="true"]
{
	font-style: italic !important;
	color: red !important;
}

Is there any WebExtension API that can be used to restore this attribute, or provide similar functionality to change the tab presentation? After a brief search, it looks like the only way to affect a tab's presentation is to modify the page title using content JS injected via the "tabs" API. Which is super gross.
(In reply to Matthew Turnbull [Bluefang] from comment #11)
> Is there any WebExtension API that can be used to restore this attribute,

Bug 1421785 was about that.
This was not a bug, tho... While unused, it was particularly useful for custom CSS implementations. Is there any possibility of a external implementation of the 'unread' attribute?
Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:62.0) Gecko/20100101 Firefox/62.0
20180625141512

(In reply to Matthew Turnbull [Bluefang] from comment #11)
> I have long had a userChrome style leveraging this attribute:

I haven't tested extensively, but it seems
.tabbrowser-tab[notselectedsinceload="true"] can be used for links opened in a new background tab.
.tabbrowser-tab[pending="true"] can be used for background tabs opened by Session Restore.

(In reply to Zero-ELEC from comment #13)
> Is there any possibility of a external implementation of the 'unread' attribute?

I think comment 12 already answered that. And comment 5 requested any advocacy be taken someplace like the firefox-dev mailing list.
https://mail.mozilla.org/listinfo/firefox-dev
(In reply to Gingerbread Man from comment #14)

> I haven't tested extensively, but it seems
> .tabbrowser-tab[notselectedsinceload="true"] can be used for links opened in
> a new background tab.

It helps (if you don't forget to set toolkit.cosmeticAnimations.enabled to true prematurely). But another problem appears: Once "notselectedsinceload" attribute is set to true, it is never going to return its false state.
Hello, I am being affect by this bug too, any chance of fixing ? I try the workaround above but its not good, a kludge. Still need this feature thank you

First of all, I find it quite ironic that this is put under "enhancement", when it clearly limits the browser's abilities.
Now not only did you waste time discussing this "enhancement", you also wasted time removing a feature used by users, a feature that bothered nobody and is not in any way memory-intensive or anything. What for?

If you want to fix a real bug, go ahead and make sure ".tabbrowser-tab[notselectedsinceload="true"]" works, by setting the attribute correctly, once the tab was selected. At least this way we could have a workaround to restore the destroyed feature. Or just put the three lines back in.

Damn it, you developers are killing all the customizability aren't you? Are you paid to cripple Firefox?

You need to log in before you can comment on or make changes to this bug.