Remove menulist-base binding

RESOLVED FIXED in Firefox 61

Status

()

RESOLVED FIXED
7 months ago
7 months ago

People

(Reporter: bgrins, Assigned: eoger)

Tracking

(Blocks: 1 bug)

unspecified
mozilla61
Points:
---

Firefox Tracking Flags

(firefox61 fixed)

Details

Attachments

(1 attachment)

(Reporter)

Description

7 months ago
This is only extended once and it's never directly bound to anything. So we could either move the <resources> tag into "menulist" https://dxr.mozilla.org/mozilla-central/rev/325ef357e5b73d63794e47c02c7f8e7cf58ccb48/toolkit/content/widgets/menulist.xml#13,20 or do the following:

- Move the menulist skin CSS sheet into components.css and delete the binding
- Move the single rule from the content menulist.css into xul.css (https://searchfox.org/mozilla-central/source/toolkit/content/menulist.css)
- Delete the binding without modifying menulist
Comment hidden (mozreview-request)
(Reporter)

Comment 2

7 months ago
Comment on attachment 8967929 [details]
Bug 1453958 - Remove menulist-base binding.

Thank you for the patch! Forwarding the review request
Attachment #8967929 - Flags: review?(bgrinstead) → review?(dao+bmo)

Comment 3

7 months ago
mozreview-review
Comment on attachment 8967929 [details]
Bug 1453958 - Remove menulist-base binding.

https://reviewboard.mozilla.org/r/236618/#review242542

::: toolkit/content/xul.css:834
(Diff revision 1)
>  
> +html|*.menulist-editable-input {
> +  -moz-appearance: none !important;
> +  background: transparent ! important;
> +  -moz-box-flex: 1;
> +}

Please move this before the dropmarker rule.

Thanks!
Attachment #8967929 - Flags: review?(dao+bmo) → review+
(Assignee)

Updated

7 months ago
Assignee: nobody → eoger
Status: NEW → ASSIGNED
Comment hidden (mozreview-request)

Comment 5

7 months ago
Pushed by eoger@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/3ce30f63aa94
Remove menulist-base binding. r=dao

Comment 6

7 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/3ce30f63aa94
Status: ASSIGNED → RESOLVED
Last Resolved: 7 months ago
status-firefox61: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
Moving to Core:XUL per https://bugzilla.mozilla.org/show_bug.cgi?id=1455336
Component: XP Toolkit/Widgets: XUL → XUL
You need to log in before you can comment on or make changes to this bug.