1453958 - Remove menulist-base binding

Status: RESOLVED FIXED

(Core :: XUL, task)

Description

[Brian Grinstead [:bgrins]]

This is only extended once and it's never directly bound to anything. So we could either move the <resources> tag into "menulist" https://dxr.mozilla.org/mozilla-central/rev/325ef357e5b73d63794e47c02c7f8e7cf58ccb48/toolkit/content/widgets/menulist.xml#13,20 or do the following:

- Move the menulist skin CSS sheet into components.css and delete the binding
- Move the single rule from the content menulist.css into xul.css (https://searchfox.org/mozilla-central/source/toolkit/content/menulist.css)
- Delete the binding without modifying menulist

Comment 1

[Edouard Oger [:eoger]]

Attachment: Bug 1453958 - Remove menulist-base binding.

Review commit: https://reviewboard.mozilla.org/r/236618/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/236618/

Comment 2

[Brian Grinstead [:bgrins]]

Comment on attachment 8967929 [details]
Bug 1453958 - Remove menulist-base binding.

Thank you for the patch! Forwarding the review request

Comment 3

[Dão Gottwald [:dao]]

Comment on attachment 8967929 [details]
Bug 1453958 - Remove menulist-base binding.

https://reviewboard.mozilla.org/r/236618/#review242542

::: toolkit/content/xul.css:834
(Diff revision 1)
>  
> +html|*.menulist-editable-input {
> +  -moz-appearance: none !important;
> +  background: transparent ! important;
> +  -moz-box-flex: 1;
> +}

Please move this before the dropmarker rule.

Thanks!

Comment 4

[Edouard Oger [:eoger]]

Comment on attachment 8967929 [details]
Bug 1453958 - Remove menulist-base binding.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/236618/diff/1-2/

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3ce30f63aa94
Remove menulist-base binding. r=dao

Comment 6

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/3ce30f63aa94

Comment 7

[Firefox Bug Husbandry Bot]

Moving to Core:XUL per https://bugzilla.mozilla.org/show_bug.cgi?id=1455336