Use enums in PDocAccessible IPDL to simplify safe serialization

RESOLVED FIXED in Firefox 61

Status

()

enhancement
P1
normal
RESOLVED FIXED
a year ago
a year ago

People

(Reporter: Alex_Gaynor, Assigned: Alex_Gaynor)

Tracking

Trunk
mozilla61
Points:
---

Firefox Tracking Flags

(firefox61 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

a year ago
Currently the PDocAccessibleParent manually converts ints to enums; IPDL natively supports enums so we can use those to simplify safe deserialization of them.
Comment on attachment 8967758 [details]
Bug 1453979 - use ContiguousEnumSerializerInclusive for serializing enums in a11y IPC code;

https://reviewboard.mozilla.org/r/236460/#review242418

Nice! Thanks for the patchc!
Attachment #8967758 - Flags: review?(mzehe) → review+
(Assignee)

Updated

a year ago
Keywords: checkin-needed

Comment 3

a year ago
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/99c2396a4c87
use ContiguousEnumSerializerInclusive for serializing enums in a11y IPC code; r=MarcoZ
Keywords: checkin-needed
Backed out changeset 99c2396a4c87 (bug 1453979) for mozmake.exe failures in z:/build/build/src/accessible/ipc/win/DocAccessibleChild.cpp on a CLOSED TREE

Problematic push: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=99c2396a4c8767d152e437299664d0e15c3d8e35&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=runnable
Failure: https://treeherder.mozilla.org/#/jobs?repo=autoland&fromchange=a7561379843f63c1a548ff1842ba5e7359580d43&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=runnable&selectedJob=173926284
Backout: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=ae7c124af9f03b88cf5efd53d4d2f9383fa959f2&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=runnable
Log: https://treeherder.mozilla.org/logviewer.html#?job_id=173926284&repo=autoland&lineNumber=21149

18:01:53     INFO -  z:/build/build/src/accessible/ipc/win/DocAccessibleChild.cpp(269): error C2664: 'bool mozilla::a11y::PDocAccessibleChild::SendRoleChangedEvent(const mozilla::a11y::PDocAccessibleChild::role &)': cannot convert argument 1 from 'const uint32_t' to 'const mozilla::a11y::PDocAccessibleChild::role &'
18:01:53     INFO -  z:/build/build/src/accessible/ipc/win/DocAccessibleChild.cpp(269): note: Reason: cannot convert from 'const uint32_t' to 'const mozilla::a11y::PDocAccessibleChild::role'
18:01:53     INFO -  z:/build/build/src/accessible/ipc/win/DocAccessibleChild.cpp(269): note: Conversion to enumeration type requires an explicit cast (static_cast, C-style cast or function-style cast)
18:01:53     INFO -  z:/build/build/src/config/rules.mk:1024: recipe for target 'DocAccessibleChild.obj' failed
18:01:53     INFO -  mozmake.EXE[4]: *** [DocAccessibleChild.obj] Error 2
18:01:53     INFO -  mozmake.EXE[4]: Leaving directory 'z:/build/build/src/obj-firefox/accessible/ipc/win'
18:01:53     INFO -  mozmake.EXE[4]: *** Waiting for unfinished jobs....
Flags: needinfo?(agaynor)
Comment hidden (mozreview-request)
(Assignee)

Comment 6

a year ago
Whoops, failed to update some of the windows code. Patch updated and confirmed on try:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=263c6c61e4f471b4ffed0c7319d1c0881849501e
Flags: needinfo?(agaynor)
Keywords: checkin-needed

Comment 7

a year ago
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/c3296237754d
use ContiguousEnumSerializerInclusive for serializing enums in a11y IPC code; r=MarcoZ
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/c3296237754d
Status: NEW → RESOLVED
Last Resolved: a year ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
Depends on: 1454628
You need to log in before you can comment on or make changes to this bug.