Closed Bug 1454007 Opened 3 years ago Closed 3 years ago

[wpt-sync] Sync PR 10461 - Streams: Constructors property lookup order

Categories

(Core :: DOM: Core & HTML, enhancement, P4)

enhancement

Tracking

()

RESOLVED FIXED
mozilla61
Tracking Status
firefox61 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 10461 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/w3c/web-platform-tests/pull/10461
Details from upstream follow.

Adam Rice <ricea@chromium.org> wrote:
>  Streams: Constructors property lookup order
>  
>  ReadableStream, WritableStream and TransformStream look up and validate
>  properties on their arguments. Add tests to verify that these lookups
>  and validations happen in the order specified by the standard.
>  
>  https://github.com/whatwg/streams/pull/922 adjusts some of the ordering
>  of these operations. These tests correspond to that change.
>  
>  A new utility file streams/resources/constructor-ordering.js contains
>  functions to construct objects which track property lookups and
>  validations and can cause them to fail.
>  
>  For each constructor the constructor.js file contains a list of the
>  expected operations in order, and a test case to verify it.
>  
>  A test in streams/transform-streams/properties.js already detected the
>  ordering of property accesses by the TransformStream constructor.
>  writableStrategy is now accessed before readableStrategy to match the
>  order of the constructor arguments, and so the expectations of this test
>  are changed to match.
Component: web-platform-tests → DOM
Product: Testing → Core
Ran 20 tests and 246[linux32-debug,linux64-debug], 311[linux32-opt,linux64-opt] subtests
OK     : 17[linux32-opt,linux64-opt], 13[linux32-debug,linux64-debug]
PASS   : 37[linux32-debug,linux64-debug], 62[linux32-opt,linux64-opt]
CRASH  : 4[linux32-debug,linux64-debug]
FAIL   : 209[linux32-debug,linux64-debug], 249[linux32-opt,linux64-opt]
ERROR  : 3

Tests that CRASH:
/streams/readable-byte-streams/constructor.dedicatedworker.html: [linux32-debug,linux64-debug]
/streams/readable-byte-streams/constructor.html: [linux32-debug,linux64-debug]
/streams/readable-byte-streams/constructor.serviceworker.https.html: [linux32-debug,linux64-debug]
/streams/readable-byte-streams/constructor.sharedworker.html: [linux32-debug,linux64-debug]

New tests that have failures or other problems:
/streams/readable-byte-streams/constructor.dedicatedworker.html
    ReadableStream constructor should stop after get on autoAllocateChunkSize fails: FAIL[linux32-opt,linux64-opt]
    ReadableStream constructor should stop after get on cancel fails: FAIL[linux32-opt,linux64-opt]
    ReadableStream constructor should stop after get on pull fails: FAIL[linux32-opt,linux64-opt]
    ReadableStream constructor should stop after get on start fails: FAIL[linux32-opt,linux64-opt]
    ReadableStream constructor should stop after tonumber on autoAllocateChunkSize fails: FAIL[linux32-opt,linux64-opt]
    ReadableStream constructor should stop after validate on autoAllocateChunkSize fails: FAIL[linux32-opt,linux64-opt]
    ReadableStream constructor should stop after validate on cancel fails: FAIL[linux32-opt,linux64-opt]
    ReadableStream constructor should stop after validate on pull fails: FAIL[linux32-opt,linux64-opt]
    ReadableStream constructor should stop after validate on size fails: FAIL[linux32-opt,linux64-opt]
    ReadableStream constructor should stop after validate on start fails: FAIL[linux32-opt,linux64-opt]
/streams/readable-byte-streams/constructor.html
    ReadableStream constructor should stop after get on autoAllocateChunkSize fails: FAIL[linux32-opt,linux64-opt]
    ReadableStream constructor should stop after get on cancel fails: FAIL[linux32-opt,linux64-opt]
    ReadableStream constructor should stop after get on pull fails: FAIL[linux32-opt,linux64-opt]
    ReadableStream constructor should stop after get on start fails: FAIL[linux32-opt,linux64-opt]
    ReadableStream constructor should stop after tonumber on autoAllocateChunkSize fails: FAIL[linux32-opt,linux64-opt]
    ReadableStream constructor should stop after validate on autoAllocateChunkSize fails: FAIL[linux32-opt,linux64-opt]
    ReadableStream constructor should stop after validate on cancel fails: FAIL[linux32-opt,linux64-opt]
    ReadableStream constructor should stop after validate on pull fails: FAIL[linux32-opt,linux64-opt]
    ReadableStream constructor should stop after validate on size fails: FAIL[linux32-opt,linux64-opt]
    ReadableStream constructor should stop after validate on start fails: FAIL[linux32-opt,linux64-opt]
/streams/readable-byte-streams/constructor.serviceworker.https.html
    ReadableStream constructor should stop after get on autoAllocateChunkSize fails: FAIL[linux32-opt,linux64-opt]
    ReadableStream constructor should stop after get on cancel fails: FAIL[linux32-opt,linux64-opt]
    ReadableStream constructor should stop after get on pull fails: FAIL[linux32-opt,linux64-opt]
    ReadableStream constructor should stop after get on start fails: FAIL[linux32-opt,linux64-opt]
    ReadableStream constructor should stop after tonumber on autoAllocateChunkSize fails: FAIL[linux32-opt,linux64-opt]
    ReadableStream constructor should stop after validate on autoAllocateChunkSize fails: FAIL[linux32-opt,linux64-opt]
    ReadableStream constructor should stop after validate on cancel fails: FAIL[linux32-opt,linux64-opt]
    ReadableStream constructor should stop after validate on pull fails: FAIL[linux32-opt,linux64-opt]
    ReadableStream constructor should stop after validate on size fails: FAIL[linux32-opt,linux64-opt]
    ReadableStream constructor should stop after validate on start fails: FAIL[linux32-opt,linux64-opt]
/streams/readable-byte-streams/constructor.sharedworker.html
    ReadableStream constructor should stop after get on autoAllocateChunkSize fails: FAIL[linux32-opt,linux64-opt]
    ReadableStream constructor should stop after get on cancel fails: FAIL[linux32-opt,linux64-opt]
    ReadableStream constructor should stop after get on pull fails: FAIL[linux32-opt,linux64-opt]
    ReadableStream constructor should stop after get on start fails: FAIL[linux32-opt,linux64-opt]
    ReadableStream constructor should stop after tonumber on autoAllocateChunkSize fails: FAIL[linux32-opt,linux64-opt]
    ReadableStream constructor should stop after validate on autoAllocateChunkSize fails: FAIL[linux32-opt,linux64-opt]
    ReadableStream constructor should stop after validate on cancel fails: FAIL[linux32-opt,linux64-opt]
    ReadableStream constructor should stop after validate on pull fails: FAIL[linux32-opt,linux64-opt]
    ReadableStream constructor should stop after validate on size fails: FAIL[linux32-opt,linux64-opt]
    ReadableStream constructor should stop after validate on start fails: FAIL[linux32-opt,linux64-opt]
/streams/readable-streams/constructor.dedicatedworker.html
    ReadableStream constructor should stop after get on cancel fails: FAIL
    ReadableStream constructor should stop after get on pull fails: FAIL
    ReadableStream constructor should stop after get on start fails: FAIL
    ReadableStream constructor should stop after validate on cancel fails: FAIL
    ReadableStream constructor should stop after validate on pull fails: FAIL
    ReadableStream constructor should stop after validate on start fails: FAIL
/streams/readable-streams/constructor.html
    ReadableStream constructor should stop after get on cancel fails: FAIL
    ReadableStream constructor should stop after get on pull fails: FAIL
    ReadableStream constructor should stop after get on start fails: FAIL
    ReadableStream constructor should stop after validate on cancel fails: FAIL
    ReadableStream constructor should stop after validate on pull fails: FAIL
    ReadableStream constructor should stop after validate on start fails: FAIL
/streams/readable-streams/constructor.serviceworker.https.html
    ReadableStream constructor should stop after get on cancel fails: FAIL
    ReadableStream constructor should stop after get on pull fails: FAIL
    ReadableStream constructor should stop after get on start fails: FAIL
    ReadableStream constructor should stop after validate on cancel fails: FAIL
    ReadableStream constructor should stop after validate on pull fails: FAIL
    ReadableStream constructor should stop after validate on start fails: FAIL
/streams/readable-streams/constructor.sharedworker.html
    ReadableStream constructor should stop after get on cancel fails: FAIL
    ReadableStream constructor should stop after get on pull fails: FAIL
    ReadableStream constructor should stop after get on start fails: FAIL
    ReadableStream constructor should stop after validate on cancel fails: FAIL
    ReadableStream constructor should stop after validate on pull fails: FAIL
    ReadableStream constructor should stop after validate on start fails: FAIL
/streams/transform-streams/constructor.dedicatedworker.html
    TransformStream constructor should stop after get on flush fails: FAIL
    TransformStream constructor should stop after get on highWaterMark (readable) fails: FAIL
    TransformStream constructor should stop after get on highWaterMark (writable) fails: FAIL
    TransformStream constructor should stop after get on readableType fails: FAIL
    TransformStream constructor should stop after get on size (readable) fails: FAIL
    TransformStream constructor should stop after get on size (writable) fails: FAIL
    TransformStream constructor should stop after get on start fails: FAIL
    TransformStream constructor should stop after get on transform fails: FAIL
    TransformStream constructor should stop after get on writableType fails: FAIL
    TransformStream constructor should stop after tonumber on highWaterMark (readable) fails: FAIL
    TransformStream constructor should stop after tonumber on highWaterMark (writable) fails: FAIL
    TransformStream constructor should stop after validate on flush fails: FAIL
    TransformStream constructor should stop after validate on highWaterMark (readable) fails: FAIL
    TransformStream constructor should stop after validate on highWaterMark (writable) fails: FAIL
    TransformStream constructor should stop after validate on readableType fails: FAIL
    TransformStream constructor should stop after validate on size (readable) fails: FAIL
    TransformStream constructor should stop after validate on size (writable) fails: FAIL
    TransformStream constructor should stop after validate on start fails: FAIL
    TransformStream constructor should stop after validate on transform fails: FAIL
    TransformStream constructor should stop after validate on writableType fails: FAIL
/streams/transform-streams/constructor.html
    TransformStream constructor should stop after get on flush fails: FAIL
    TransformStream constructor should stop after get on highWaterMark (readable) fails: FAIL
    TransformStream constructor should stop after get on highWaterMark (writable) fails: FAIL
    TransformStream constructor should stop after get on readableType fails: FAIL
    TransformStream constructor should stop after get on size (readable) fails: FAIL
    TransformStream constructor should stop after get on size (writable) fails: FAIL
    TransformStream constructor should stop after get on start fails: FAIL
    TransformStream constructor should stop after get on transform fails: FAIL
    TransformStream constructor should stop after get on writableType fails: FAIL
    TransformStream constructor should stop after tonumber on highWaterMark (readable) fails: FAIL
    TransformStream constructor should stop after tonumber on highWaterMark (writable) fails: FAIL
    TransformStream constructor should stop after validate on flush fails: FAIL
    TransformStream constructor should stop after validate on highWaterMark (readable) fails: FAIL
    TransformStream constructor should stop after validate on highWaterMark (writable) fails: FAIL
    TransformStream constructor should stop after validate on readableType fails: FAIL
    TransformStream constructor should stop after validate on size (readable) fails: FAIL
    TransformStream constructor should stop after validate on size (writable) fails: FAIL
    TransformStream constructor should stop after validate on start fails: FAIL
    TransformStream constructor should stop after validate on transform fails: FAIL
    TransformStream constructor should stop after validate on writableType fails: FAIL
/streams/transform-streams/constructor.serviceworker.https.html
    TransformStream constructor should stop after get on flush fails: FAIL
    TransformStream constructor should stop after get on highWaterMark (readable) fails: FAIL
    TransformStream constructor should stop after get on highWaterMark (writable) fails: FAIL
    TransformStream constructor should stop after get on readableType fails: FAIL
    TransformStream constructor should stop after get on size (readable) fails: FAIL
    TransformStream constructor should stop after get on size (writable) fails: FAIL
    TransformStream constructor should stop after get on start fails: FAIL
    TransformStream constructor should stop after get on transform fails: FAIL
    TransformStream constructor should stop after get on writableType fails: FAIL
    TransformStream constructor should stop after tonumber on highWaterMark (readable) fails: FAIL
    TransformStream constructor should stop after tonumber on highWaterMark (writable) fails: FAIL
    TransformStream constructor should stop after validate on flush fails: FAIL
    TransformStream constructor should stop after validate on highWaterMark (readable) fails: FAIL
    TransformStream constructor should stop after validate on highWaterMark (writable) fails: FAIL
    TransformStream constructor should stop after validate on readableType fails: FAIL
    TransformStream constructor should stop after validate on size (readable) fails: FAIL
    TransformStream constructor should stop after validate on size (writable) fails: FAIL
    TransformStream constructor should stop after validate on start fails: FAIL
    TransformStream constructor should stop after validate on transform fails: FAIL
    TransformStream constructor should stop after validate on writableType fails: FAIL
/streams/transform-streams/constructor.sharedworker.html
    TransformStream constructor should stop after get on flush fails: FAIL
    TransformStream constructor should stop after get on highWaterMark (readable) fails: FAIL
    TransformStream constructor should stop after get on highWaterMark (writable) fails: FAIL
    TransformStream constructor should stop after get on readableType fails: FAIL
    TransformStream constructor should stop after get on size (readable) fails: FAIL
    TransformStream constructor should stop after get on size (writable) fails: FAIL
    TransformStream constructor should stop after get on start fails: FAIL
    TransformStream constructor should stop after get on transform fails: FAIL
    TransformStream constructor should stop after get on writableType fails: FAIL
    TransformStream constructor should stop after tonumber on highWaterMark (readable) fails: FAIL
    TransformStream constructor should stop after tonumber on highWaterMark (writable) fails: FAIL
    TransformStream constructor should stop after validate on flush fails: FAIL
    TransformStream constructor should stop after validate on highWaterMark (readable) fails: FAIL
    TransformStream constructor should stop after validate on highWaterMark (writable) fails: FAIL
    TransformStream constructor should stop after validate on readableType fails: FAIL
    TransformStream constructor should stop after validate on size (readable) fails: FAIL
    TransformStream constructor should stop after validate on size (writable) fails: FAIL
    TransformStream constructor should stop after validate on start fails: FAIL
    TransformStream constructor should stop after validate on transform fails: FAIL
    TransformStream constructor should stop after validate on writableType fails: FAIL
/streams/writable-streams/constructor.dedicatedworker.html
    WritableStream constructor should stop after get on abort fails: FAIL
    WritableStream constructor should stop after get on close fails: FAIL
    WritableStream constructor should stop after get on highWaterMark fails: FAIL
    WritableStream constructor should stop after get on size fails: FAIL
    WritableStream constructor should stop after get on start fails: FAIL
    WritableStream constructor should stop after get on type fails: FAIL
    WritableStream constructor should stop after get on write fails: FAIL
    WritableStream constructor should stop after tonumber on highWaterMark fails: FAIL
    WritableStream constructor should stop after validate on abort fails: FAIL
    WritableStream constructor should stop after validate on close fails: FAIL
    WritableStream constructor should stop after validate on highWaterMark fails: FAIL
    WritableStream constructor should stop after validate on size fails: FAIL
    WritableStream constructor should stop after validate on start fails: FAIL
    WritableStream constructor should stop after validate on type fails: FAIL
    WritableStream constructor should stop after validate on write fails: FAIL
    WritableStreamDefaultController constructor should throw: FAIL
/streams/writable-streams/constructor.html
    WritableStream constructor should stop after get on abort fails: FAIL
    WritableStream constructor should stop after get on close fails: FAIL
    WritableStream constructor should stop after get on highWaterMark fails: FAIL
    WritableStream constructor should stop after get on size fails: FAIL
    WritableStream constructor should stop after get on start fails: FAIL
    WritableStream constructor should stop after get on type fails: FAIL
    WritableStream constructor should stop after get on write fails: FAIL
    WritableStream constructor should stop after tonumber on highWaterMark fails: FAIL
    WritableStream constructor should stop after validate on abort fails: FAIL
    WritableStream constructor should stop after validate on close fails: FAIL
    WritableStream constructor should stop after validate on highWaterMark fails: FAIL
    WritableStream constructor should stop after validate on size fails: FAIL
    WritableStream constructor should stop after validate on start fails: FAIL
    WritableStream constructor should stop after validate on type fails: FAIL
    WritableStream constructor should stop after validate on write fails: FAIL
    WritableStreamDefaultController constructor should throw: FAIL
/streams/writable-streams/constructor.serviceworker.https.html
    WritableStream constructor should stop after get on abort fails: FAIL
    WritableStream constructor should stop after get on close fails: FAIL
    WritableStream constructor should stop after get on highWaterMark fails: FAIL
    WritableStream constructor should stop after get on size fails: FAIL
    WritableStream constructor should stop after get on start fails: FAIL
    WritableStream constructor should stop after get on type fails: FAIL
    WritableStream constructor should stop after get on write fails: FAIL
    WritableStream constructor should stop after tonumber on highWaterMark fails: FAIL
    WritableStream constructor should stop after validate on abort fails: FAIL
    WritableStream constructor should stop after validate on close fails: FAIL
    WritableStream constructor should stop after validate on highWaterMark fails: FAIL
    WritableStream constructor should stop after validate on size fails: FAIL
    WritableStream constructor should stop after validate on start fails: FAIL
    WritableStream constructor should stop after validate on type fails: FAIL
    WritableStream constructor should stop after validate on write fails: FAIL
    WritableStreamDefaultController constructor should throw: FAIL
/streams/writable-streams/constructor.sharedworker.html
    WritableStream constructor should stop after get on abort fails: FAIL
    WritableStream constructor should stop after get on close fails: FAIL
    WritableStream constructor should stop after get on highWaterMark fails: FAIL
    WritableStream constructor should stop after get on size fails: FAIL
    WritableStream constructor should stop after get on start fails: FAIL
    WritableStream constructor should stop after get on type fails: FAIL
    WritableStream constructor should stop after get on write fails: FAIL
    WritableStream constructor should stop after tonumber on highWaterMark fails: FAIL
    WritableStream constructor should stop after validate on abort fails: FAIL
    WritableStream constructor should stop after validate on close fails: FAIL
    WritableStream constructor should stop after validate on highWaterMark fails: FAIL
    WritableStream constructor should stop after validate on size fails: FAIL
    WritableStream constructor should stop after validate on start fails: FAIL
    WritableStream constructor should stop after validate on type fails: FAIL
    WritableStream constructor should stop after validate on write fails: FAIL
    WritableStreamDefaultController constructor should throw: FAIL
Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/4d864d2b3e46
[wpt PR 10461] - Streams: Constructors property lookup order, a=testonly
https://hg.mozilla.org/integration/mozilla-inbound/rev/a8cde567d6ad
[wpt PR 10461] - Update wpt metadata, a=testonly
https://hg.mozilla.org/mozilla-central/rev/4d864d2b3e46
https://hg.mozilla.org/mozilla-central/rev/a8cde567d6ad
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla61
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.